I personally prefer to keep the simple demo. As @Huxing said, it is very convenient to start dubbo with demo.
Also agree with that we need to do some documentation updates. Zonghai Shang <y...@apache.org> 于2018年9月5日周三 下午2:22写道： > Hi, Huxing Zhang > > > > Sometimes I find the demo code very useful when you are working as > a developer on Dubbo. > > You can simply start the demo to do some local testing in IDE. > > Import the example project (submodule) in idea, this is relatively simple. > > > > > In fact I think remaining an official demo in Dubbo's binary release is > very necessary and important, > > users can download the release and start the demo with one shot. > > I think the demo should be managed centrally. We can choose to put the demo > in the example project, or put the example in dubbo as a submodule (such as > netty) > > > > > There are other things must be taken into consideration: > > * user already get used to the way to start dubbo with existing > demo code, this change may increase the cost for users to getting start. > > * All the documentation needs to be updated. > > > > I agree that we need to do some documentation updates. But it won't take a > long time, We can mark the demo migration in the release and give the > example project guidelines. > > Maybe we should listen to the opinions of other friends. > > yiji > Best Regards > > Huxing Zhang <hux...@apache.org> 于2018年9月5日周三 上午10:03写道： > > > Hi, > > > > On Tue, Sep 4, 2018 at 9:49 PM Zonghai Shang <y...@apache.org> wrote: > > > > > > Hello Dubbo Community, > > > > > > I think it's time to delete the demo module.Because all the examples > are > > > maintained here : https://github.com/dubbo/dubbo-samples > > > > Sometimes I find the demo code very useful when you are working as a > > developer on Dubbo. > > You can simply start the demo to do some local testing in IDE. > > > > In fact I think remaining an official demo in Dubbo's binary release > > is very necessary and important, users can download the release and > > start the demo with one shot. > > > > If the demo has been moved to https://github.com/dubbo/dubbo-samples, > > I am not sure it is legal to be included in the binary release, > > because it is not Apache code anymore. > > > > There are other things must be taken into consideration: > > * user already get used to the way to start dubbo with existing demo > > code, this change may increase the cost for users to getting start. > > * All the documentation needs to be updated. > > > > > > > > > > yiji > > > Best Regards > > > > > > > > -- > > Best Regards！ > > Huxing > > >
