I think only provide a docker-compose file in project is not a good idea, this 
still require user to compile and build image in their local. It will spend 
many time since it require npm dependencies and maven dependencies.

As Justin's suggestion, we can provide official docker image in docker-hub with 
release version only, if user want to latest code, their can use dockerfile to 
build by themselves.

On 2019/03/14 07:48:08, Ian Luo <[email protected]> wrote: 
> or at least we can bundle a docker-compose.yaml in dubbo admin project.
> 
> -Ian.
> 
> On Wed, Mar 13, 2019 at 11:55 AM Justin Mclean <[email protected]>
> wrote:
> 
> > Hi,
> >
> > > I've see a dubbo-admin docker image[1], which is maintained by one of
> > > the Dubbo PPMC. To some extend this might be a violation of ASF
> > > distribution policy - we should always distribute the source/binary
> > > with the approval of Dubbo PPMC.
> >
> > I can see that this docker image is providing unreleased code the general
> > public that’s probably not the best idea. I think it would be better if
> > this docker image only pointed to the latest official release. There are
> > some branding and trademark issues here as well.
> >
> > Thanks,
> > Justin
> 

Reply via email to