Hi, > Since Justin suggests you to put all artifacts in RC2 directory, you may > not consider this email as an official vote, but I did spend a little time > on sanity check against your second release.
While potentially confusing, I would leave this vote open and treat it as “official”. Take my suggestions as improvements for next time. > For the source code, it looks fine except for one file: > protocol/mock/mock_invoker.go doesn't have apache license header though > it's generated by tools. You may consider to add one. Generated files don’t need headers, but you could add one if you want. Either way it’s not a release blocker. Thanks, Justin
