To Mr Ian and Mr Justin, The source file protocol/mock/mock_invoker.go is generated by a mock tool gomock(github.com/golang/mock/gomock). The file has a header declaration as follows,
''' // Code generated by MockGen. DO NOT EDIT. // Source: invoker.go // Package mock is a generated GoMock package. package mock ''' I think I do not need to add license on the file header. Ian Luo <[email protected]> 于2019年9月9日周一 下午10:25写道： > Alex, > > Since Justin suggests you to put all artifacts in RC2 directory, you may > not consider this email as an official vote, but I did spend a little time > on sanity check against your second release. > > For the source code, it looks fine except for one file: > protocol/mock/mock_invoker.go doesn't have apache license header though > it's generated by tools. You may consider to add one. > > Thanks, > -Ian. > > On Sat, Sep 7, 2019 at 10:53 PM stocks alex <[email protected]> wrote: > > > To Mr Justin Mclean, > > > > Thx for your good advice. I will do it as your suggestion. > > > > Justin Mclean <[email protected]> 于2019年9月7日周六 下午10:31写道： > > > > > Hi, > > > > > > > This is a call for vote to release Apache Dubbo-go version v1.1.0 > RC2. > > > > The release candidates: > > > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/ > > > > > > Please don’t overwrite the exacting artefact being voted on as we then > > > have no way of knowing which they voted on. They could also be cached > and > > > people get the wrong ones. It’s best to make a RC1, RC2 etc etc > directory > > > and put the release in that. > > > > > > Thanks, > > > Justin > > >
