+1
I checked the following items:
[v] Are release files in correct location?
[v] Do release files have the word incubating in their name?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[v] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[v] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
[ ] Does the software have a compatible license?
[ ] Are all software licenses mentioned in LICENSE?
[ ] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this
NOTICE file?
[v] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?
On my mac laptop, I could compile successfully but there's one failed unit
test against net.go. I believe this issue [1] can be fixed with [2] in the
next release.
Is the issue minor?
[v] Yes [ ] No [ ] Unsure
Could it possibly be fixed in the next release?
[v] Yes [ ] No [ ] Unsure
I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because...
Regards,
-Ian.
1. https://github.com/apache/dubbo-go/issues/207
2. https://github.com/apache/dubbo-go/pull/209
On Sat, Sep 7, 2019 at 6:54 PM stocks alex <[email protected]> wrote:
> Hello Dubbo/Dubbogo Community,
>
> This is a call for vote to release Apache Dubbo-go version v1.1.0 RC2.
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/
> Git tag for the release:
> https://github.com/apache/dubbo-go/tree/1.1
> Hash for the release tag:
> 1747ef485b1bf9e264116b0f73b36ecf452445e4
> Release Notes:
> https://github.com/apache/dubbo-go/blob/1.1/CHANGE.md
> The artifacts have been signed with Key :0D963B35B7F1E689, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> Thanks,
> The Apache Dubbo-go Team
>
