> - NOTICE doesn’t need to list information about protobuf as the project > doesn’t have a NOTICE file
I added the protobuf info in the NOTICE file several versions ago when adding gRPC support. I remember it clearly says in some place that a declaration must be included in a project's NOTICE file if there’s abt reference of the source code. I will check the protobuf codes later for sure. I think we can fix it in the next release. Jun > On May 10, 2021, at 11:31 AM, Justin Mclean <[email protected]> wrote: > > Hi, > > +1 binding but there a couple of minor license and notice issues that need to > be corrected. > > I checked: > - signatures and hashes are fine > - LICENSE should also list InternalThreadLocal.java > - NOTICE doesn’t need to list information about protobuf as the project > doesn’t have a NOTICE file > - A few files are missing ASF headers, please add them e.g. [1] > - No unexpected binary files > - Can compile from source. > > Thanks, > Justin > > 1. ./dubbo-rpc/dubbo-rpc-thrift/src/test/thrift/Demo.thrift
