Hi, Justin > - LICENSE should also list InternalThreadLocal.java
I have checked that InternalThreadLocal.java is learned from `io.netty.util.concurrent.FastThreadLocal`[1] which has been declared in the LICENSE file[2]. There does not exist a file like `io.netty.util.concurrent.InternalThreadLocal` in Netty. And according to the LICENSE file we have declared the whole `org.apache.dubbo.common.threadlocal` may contain a modified portion of 'Netty'. I think it may not be necessary for us to change anything in the LICENSE file? [1] https://github.com/apache/dubbo/blob/f29663bba655c9451b9db75b94d5cf945f0e7901/dubbo-common/src/main/java/org/apache/dubbo/common/threadlocal/InternalThreadLocal.java#L32 [2] https://github.com/apache/dubbo/blob/f29663bba655c9451b9db75b94d5cf945f0e7901/LICENSE#L216 [3] https://github.com/apache/dubbo/blob/f29663bba655c9451b9db75b94d5cf945f0e7901/LICENSE#L211 Albumen On Mon, May 10, 2021 at 11:32 AM Justin Mclean <[email protected]> wrote: > Hi, > > +1 binding but there a couple of minor license and notice issues that need > to be corrected. > > I checked: > - signatures and hashes are fine > - LICENSE should also list InternalThreadLocal.java > - NOTICE doesn’t need to list information about protobuf as the project > doesn’t have a NOTICE file > - A few files are missing ASF headers, please add them e.g. [1] > - No unexpected binary files > - Can compile from source. > > Thanks, > Justin > > 1. ./dubbo-rpc/dubbo-rpc-thrift/src/test/thrift/Demo.thrift
