> - LICENSE should also list InternalThreadLocal.java > - A few files are missing ASF headers, please add them e.g. [1]
Are these files excluded from the LICENSE format checking tool? How com we didn’t find them running CI. Jun > On May 10, 2021, at 11:31 AM, Justin Mclean <[email protected]> wrote: > > Hi, > > +1 binding but there a couple of minor license and notice issues that need to > be corrected. > > I checked: > - signatures and hashes are fine > - LICENSE should also list InternalThreadLocal.java > - NOTICE doesn’t need to list information about protobuf as the project > doesn’t have a NOTICE file > - A few files are missing ASF headers, please add them e.g. [1] > - No unexpected binary files > - Can compile from source. > > Thanks, > Justin > > 1. ./dubbo-rpc/dubbo-rpc-thrift/src/test/thrift/Demo.thrift
