One minor problem with the "[EAGLE-${ticket_number}] message" format is the
'git am' command. When it reads patches from a mail box, it uses the
subject of each email as the commit message but it strips off any [ ... ]
at the start of the subject. So, even though we use this format in Calcite,
if we started over, I think we might use something like
"EAGLE-{ticket_number}: message" (without brackets) instead.Strictly, you don't need the "Author:" and "Reviewer:" lines because they are contained in the git metadata. But you probably know that already. Julian On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <[email protected]> wrote: > Hi, PMCs > > To help clear the dev process, i'm trying to put this into eagle WIKI. > Please advise if it's OK to all. > > The referenced commit msg format is: > > > [EAGLE-${ticket_number}] ${ticket_title} > > ${ticket_url} > > Author: ${commiter} > Reviewer: ${reviewer} > > Closes #${pr_number} from ${do_person} > > > > > > Thanks, > Ralph >
