Thanks Michael :-)
-- Hao On Wed, Dec 9, 2015 at 10:41 PM, Wu, Michael(Ziyang) <[email protected]> wrote: > Sure Hao, I’ll create a ticket for this task and update it with the status. > > Michael > > From: Hao Chen <[email protected]> > Date: Wednesday, December 09, 2015 at 16:45 > To: "[email protected]" <[email protected]>, > "Wu , Michael(Ziyang)" <[email protected]> > Subject: Re: About dev process > > Michael, I think you are working on the task creating the automatic script > for the dev process? What's the status and do you have ticket to track your > work? > > > -- > > Hao > > > On Wed, Dec 9, 2015 at 4:42 PM, Hao Chen <[email protected]> wrote: > >> Liangfei, >> >> Could you please help document the process in Eagle wiki and we could >> finalize the process ASAP? U.S. and Indian committers are pending on this >> process to merge new features. >> >> >> -- >> >> Hao >> >> >> >> On Wed, Dec 9, 2015 at 4:16 PM, Liangfei.Su <[email protected]> wrote: >> >>> Yes, the '[]' is not expected here. It should be typo when i copy from my >>> text editor. We don't need that. >>> >>> Regarding the author and reviewer, i agree that they're optional. The >>> main >>> idea here is that if we could states the name of reviewers here. (And >>> yes, >>> the reviewers should give their comments on pull request page which is >>> traceable from the ${ticket_number}, just want to make this information >>> explicitly here :) ). Let's make this info as optional. >>> >>> Ralph >>> >>> >>> On Wed, Dec 9, 2015 at 4:00 PM, Julian Hyde <[email protected]> wrote: >>> >>> > One minor problem with the "[EAGLE-${ticket_number}] message" format >>> is the >>> > 'git am' command. When it reads patches from a mail box, it uses the >>> > subject of each email as the commit message but it strips off any [ >>> ... ] >>> > at the start of the subject. So, even though we use this format in >>> Calcite, >>> > if we started over, I think we might use something like >>> > "EAGLE-{ticket_number}: message" (without brackets) instead. >>> > >>> > Strictly, you don't need the "Author:" and "Reviewer:" lines because >>> they >>> > are contained in the git metadata. But you probably know that already. >>> > >>> > Julian >>> > >>> > >>> > On Tue, Dec 8, 2015 at 6:46 PM, Liangfei.Su <[email protected]> >>> wrote: >>> > >>> > > Hi, PMCs >>> > > >>> > > To help clear the dev process, i'm trying to put this into eagle >>> WIKI. >>> > > Please advise if it's OK to all. >>> > > >>> > > The referenced commit msg format is: >>> > > >>> > > >>> > > [EAGLE-${ticket_number}] ${ticket_title} >>> > > >>> > > ${ticket_url} >>> > > >>> > > Author: ${commiter} >>> > > Reviewer: ${reviewer} >>> > > >>> > > Closes #${pr_number} from ${do_person} >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > Thanks, >>> > > Ralph >>> > > >>> > >>> >> >> >
