Github user murkrishn commented on the pull request:
https://github.com/apache/incubator-eagle/pull/71#issuecomment-175984692
Thanks for pointing it out @yonzhang.
To avoid the same, I will still go with determining the markdown for the
policy at PolicyProcessExecutor class (methods - createPolicyEvaluator and
onPolicyChanged) and pass on the flag to PolicyEvaluator (will be adding
another method for onPolicyUpdate which will take in a additional parameter for
markdown). This will remove the query parsing at the
SiddhiPolicyEvaluator.createSiddhiRuntime as we will be modifying it to have an
additional parameter to be passed in for markdown. Is this approach good to go ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
