Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/71#discussion_r51576885
--- Diff:
eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/dao/PolicyDefinitionEntityDAOImpl.java
---
@@ -17,14 +17,17 @@
package org.apache.eagle.policy.dao;
import org.apache.eagle.alert.entity.AbstractPolicyDefinitionEntity;
+import org.apache.eagle.alert.entity.AlertDefinitionAPIEntity;
--- End diff --
Same as above, let us make
PolicyDefinitionEntityDAO/PolicyDefinitionEntityDAOImpl not knowing specific
subtype of alert definition. Ideally, all entity/daos that specific to Alerts
should be refactor out from eagle-policies. We haven't achieve this goal, but
let us keep it clear as much as possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
