Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/71#issuecomment-176545768
@murkrishn this looks good to me except 2 minor issues
1. can we save one DB call if policyevaluator is not marked down when it is
created or previous and current policyevaluator are both not marked down.
2. is AlertDefinitionDAOImpl still used, if not, we need delete that
instead of add new code to it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
