mxsm commented on code in PR #3207:
URL: 
https://github.com/apache/incubator-eventmesh/pull/3207#discussion_r1111999259


##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/AbstractHTTPServer.java:
##########
@@ -703,14 +720,15 @@ protected void initChannel(final SocketChannel channel) {
             if (sslContext != null && useTLS) {
                 final SSLEngine sslEngine = sslContext.createSSLEngine();
                 sslEngine.setUseClientMode(false);
-                pipeline.addFirst("ssl", new SslHandler(sslEngine));
+                pipeline.addFirst(getWorkerGroup(), "ssl", new 
SslHandler(sslEngine));

Review Comment:
   - The bossGroup is used to listen and poll Accept requests
   
   - The ioGroup is mainly used to listen for READ and WRITE events. It handles 
channels registered by the Boss Group.
   
   - The workGroup is used to execute  ChannelHandlers
   
   All ChannelHandlers can be executed using a single thread pool without the 
need for separate thread pools, but in this case, the business processing is 
handled using a separate thread pool.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to