mytang0 commented on code in PR #3207:
URL:
https://github.com/apache/incubator-eventmesh/pull/3207#discussion_r1112670399
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshHTTPServer.java:
##########
@@ -116,118 +116,90 @@ public class EventMeshHTTPServer extends
AbstractHTTPServer {
public transient HTTPClientPool httpClientPool = new HTTPClientPool(10);
- public EventMeshHTTPServer(final EventMeshServer eventMeshServer,
- final EventMeshHTTPConfiguration
eventMeshHttpConfiguration) {
- super(eventMeshHttpConfiguration.getHttpServerPort(),
- eventMeshHttpConfiguration.isEventMeshServerUseTls(),
eventMeshHttpConfiguration);
+ public EventMeshHTTPServer(final EventMeshServer eventMeshServer, final
EventMeshHTTPConfiguration eventMeshHttpConfiguration) {
+
+ super(eventMeshHttpConfiguration.getHttpServerPort(),
eventMeshHttpConfiguration.isEventMeshServerUseTls(),
eventMeshHttpConfiguration);
this.eventMeshServer = eventMeshServer;
this.eventMeshHttpConfiguration = eventMeshHttpConfiguration;
this.registry = eventMeshServer.getRegistry();
this.acl = eventMeshServer.getAcl();
}
- public EventMeshServer getEventMeshServer() {
- return eventMeshServer;
- }
-
-
- public void shutdownThreadPool() {
- batchMsgExecutor.shutdown();
- adminExecutor.shutdown();
- clientManageExecutor.shutdown();
- sendMsgExecutor.shutdown();
- remoteMsgExecutor.shutdown();
- pushMsgExecutor.shutdown();
- replyMsgExecutor.shutdown();
- }
-
private void initThreadPool() {
batchMsgExecutor = ThreadPoolFactory.createThreadPoolExecutor(
-
eventMeshHttpConfiguration.getEventMeshServerBatchMsgThreadNum(),
-
eventMeshHttpConfiguration.getEventMeshServerBatchMsgThreadNum(),
- new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerBatchBlockQSize()),
- "eventMesh-batchMsg", true);
+ eventMeshHttpConfiguration.getEventMeshServerBatchMsgThreadNum(),
+ eventMeshHttpConfiguration.getEventMeshServerBatchMsgThreadNum(),
+ new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerBatchBlockQSize()),
+ "eventMesh-batchMsg", true);
sendMsgExecutor = ThreadPoolFactory.createThreadPoolExecutor(
-
eventMeshHttpConfiguration.getEventMeshServerSendMsgThreadNum(),
-
eventMeshHttpConfiguration.getEventMeshServerSendMsgThreadNum(),
- new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerSendMsgBlockQSize()),
- "eventMesh-sendMsg", true);
+ eventMeshHttpConfiguration.getEventMeshServerSendMsgThreadNum(),
+ eventMeshHttpConfiguration.getEventMeshServerSendMsgThreadNum(),
+ new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerSendMsgBlockQSize()),
+ "eventMesh-sendMsg", true);
remoteMsgExecutor = ThreadPoolFactory.createThreadPoolExecutor(
-
eventMeshHttpConfiguration.getEventMeshServerRemoteMsgThreadNum(),
-
eventMeshHttpConfiguration.getEventMeshServerRemoteMsgThreadNum(),
- new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerRemoteMsgBlockQSize()),
- "eventMesh-remoteMsg", true);
+ eventMeshHttpConfiguration.getEventMeshServerRemoteMsgThreadNum(),
+ eventMeshHttpConfiguration.getEventMeshServerRemoteMsgThreadNum(),
+ new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerRemoteMsgBlockQSize()),
+ "eventMesh-remoteMsg", true);
pushMsgExecutor = ThreadPoolFactory.createThreadPoolExecutor(
-
eventMeshHttpConfiguration.getEventMeshServerPushMsgThreadNum(),
-
eventMeshHttpConfiguration.getEventMeshServerPushMsgThreadNum(),
- new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerPushMsgBlockQSize()),
- "eventMesh-pushMsg", true);
+ eventMeshHttpConfiguration.getEventMeshServerPushMsgThreadNum(),
+ eventMeshHttpConfiguration.getEventMeshServerPushMsgThreadNum(),
+ new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerPushMsgBlockQSize()),
+ "eventMesh-pushMsg", true);
clientManageExecutor = ThreadPoolFactory.createThreadPoolExecutor(
-
eventMeshHttpConfiguration.getEventMeshServerClientManageThreadNum(),
-
eventMeshHttpConfiguration.getEventMeshServerClientManageThreadNum(),
- new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerClientManageBlockQSize()),
- "eventMesh-clientManage", true);
+
eventMeshHttpConfiguration.getEventMeshServerClientManageThreadNum(),
+
eventMeshHttpConfiguration.getEventMeshServerClientManageThreadNum(),
+ new
LinkedBlockingQueue<>(eventMeshHttpConfiguration.getEventMeshServerClientManageBlockQSize()),
+ "eventMesh-clientManage", true);
adminExecutor = ThreadPoolFactory.createThreadPoolExecutor(
- eventMeshHttpConfiguration.getEventMeshServerAdminThreadNum(),
- eventMeshHttpConfiguration.getEventMeshServerAdminThreadNum(),
- new LinkedBlockingQueue<>(50), "eventMesh-admin",
- true);
+ eventMeshHttpConfiguration.getEventMeshServerAdminThreadNum(),
+ eventMeshHttpConfiguration.getEventMeshServerAdminThreadNum(),
+ new LinkedBlockingQueue<>(50), "eventMesh-admin",
+ true);
replyMsgExecutor = ThreadPoolFactory.createThreadPoolExecutor(
-
eventMeshHttpConfiguration.getEventMeshServerReplyMsgThreadNum(),
-
eventMeshHttpConfiguration.getEventMeshServerReplyMsgThreadNum(),
- new LinkedBlockingQueue<>(100),
- "eventMesh-replyMsg", true);
- }
-
- public ThreadPoolExecutor getBatchMsgExecutor() {
- return batchMsgExecutor;
- }
-
- public ThreadPoolExecutor getSendMsgExecutor() {
- return sendMsgExecutor;
- }
-
- public ThreadPoolExecutor getReplyMsgExecutor() {
- return replyMsgExecutor;
+ eventMeshHttpConfiguration.getEventMeshServerReplyMsgThreadNum(),
+ eventMeshHttpConfiguration.getEventMeshServerReplyMsgThreadNum(),
+ new LinkedBlockingQueue<>(100),
+ "eventMesh-replyMsg", true);
}
- public ThreadPoolExecutor getPushMsgExecutor() {
- return pushMsgExecutor;
- }
-
- public ThreadPoolExecutor getClientManageExecutor() {
- return clientManageExecutor;
- }
-
- public ThreadPoolExecutor getAdminExecutor() {
- return adminExecutor;
- }
-
- public RateLimiter getMsgRateLimiter() {
- return msgRateLimiter;
- }
-
- public RateLimiter getBatchRateLimiter() {
- return batchRateLimiter;
- }
-
- public Registry getRegistry() {
- return registry;
+ public void shutdownThreadPool() {
+ if (batchMsgExecutor != null) {
+ batchMsgExecutor.shutdown();
+ }
+ if (adminExecutor != null) {
+ adminExecutor.shutdown();
+ }
+ if (clientManageExecutor != null) {
+ clientManageExecutor.shutdown();
+ }
+ if (sendMsgExecutor != null) {
+ sendMsgExecutor.shutdown();
+ }
+ if (remoteMsgExecutor != null) {
+ remoteMsgExecutor.shutdown();
+ }
+ if (pushMsgExecutor != null) {
+ pushMsgExecutor.shutdown();
+ }
+ if (replyMsgExecutor != null) {
+ replyMsgExecutor.shutdown();
+ }
}
private void init() throws Exception {
if (log.isInfoEnabled()) {
log.info("==================EventMeshHTTPServer
Initialing==================");
}
- super.init("eventMesh-http");
+ super.init("EventMesh-http");
Review Comment:
eventMesh or EventMesh? Can be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
