mytang0 commented on code in PR #3207:
URL:
https://github.com/apache/incubator-eventmesh/pull/3207#discussion_r1112410164
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/AbstractHTTPServer.java:
##########
@@ -703,14 +720,15 @@ protected void initChannel(final SocketChannel channel) {
if (sslContext != null && useTLS) {
final SSLEngine sslEngine = sslContext.createSSLEngine();
sslEngine.setUseClientMode(false);
- pipeline.addFirst("ssl", new SslHandler(sslEngine));
+ pipeline.addFirst(getWorkerGroup(), "ssl", new
SslHandler(sslEngine));
Review Comment:
Thanks, I mean bossGroup and ioGroup pipelines need to add 'SslHandler'? You
need to check the stage of SSL work, because when the old logic shares the
group, you don't need to consider this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]