> On April 25, 2015, 3:25 a.m., Ajay Yadava wrote: > > client/src/main/java/org/apache/falcon/resource/EntityList.java, line 76 > > <https://reviews.apache.org/r/32946/diff/7/?file=940065#file940065line76> > > > > Please rename the variable to be "clusters" to be consistent with > > XmlElementWrapper. Inconsistency results in issues in regression tests. > > Ying Zheng wrote: > This is to be consistent with our old style: > > @XmlElementWrapper(name = "tags") > public List<String> tag; > @XmlElementWrapper(name = "pipelines") > public List<String> pipeline; > @XmlElementWrapper(name = "clusters") > public List<String> cluster; > > In the XML output, you'll see a parent element "clusters" followed by a > few child elements "cluster" with cluster information. Same for tag and > pipeline. > > Ajay Yadava wrote: > I am recommending the java variables to be renamed to exactly match with > Xmltags. > > @XmlElementWrapper(name = "tags") > public List<String> tags; > @XmlElementWrapper(name = "pipelines") > public List<String> pipelines; > @XmlElementWrapper(name = "clusters") > public List<String> clusters; > > Reason for asking this change is that I fear this might lead to an issue > like https://issues.apache.org/jira/browse/FALCON-1152
Thanks for bringing this up, Ajay. You are right: we can't use GSON to parse the JSON output now. To make sure GSON can be used for parsing, we also need to use XMLElement instead of XMLElementWrapper and the XML element name of the variable "elements" in EntityList also needs to be changed. Since this changes the output format, we need to consider backward compatibility. I feel it is out of the scope of this jira, since we have to change existing code and output format. Shall I file an apache JIRA for this? - Ying ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32946/#review81504 ----------------------------------------------------------- On April 27, 2015, 9:44 p.m., Ying Zheng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32946/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 9:44 p.m.) > > > Review request for Falcon, Ajay Yadava, Sowmya Ramesh, Seetharam Venkatesh, > and Venkat Ranganathan. > > > Bugs: Falcon-1121 > https://issues.apache.org/jira/browse/Falcon-1121 > > > Repository: falcon-git > > > Description > ------- > > See parent JIRA Falcon-1095 for detailed descriptions: > http://issues.apache.org/jira/browse/Falcon-1095 > Four changes in total: > 1. Added API support: return feeds and processes if :entity-type is set to > schedulable; change parameter for subsequence matching from "pattern" to > "nameseq"; multi-keyword matching for entity tags with parameter "tagkeys". > 2. Added command line support. > 3. Added unit tests. > 4. Updated twiki. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 7d56b01 > client/src/main/java/org/apache/falcon/client/FalconClient.java fedcea6 > client/src/main/java/org/apache/falcon/entity/v0/Entity.java 7fb271d > client/src/main/java/org/apache/falcon/resource/EntityList.java 4c96195 > common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java > b84371f > docs/src/site/twiki/FalconCLI.twiki 0e42ae2 > docs/src/site/twiki/restapi/EntityList.twiki 08dd304 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 25cb312 > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > 6198c74 > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > 6ccfd09 > prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java > 9b0dec5 > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > 82a622c > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java dd14e9c > webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java ee5534a > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 280253d > > Diff: https://reviews.apache.org/r/32946/diff/ > > > Testing > ------- > > Unit tests passed. Also tested command line and using api calls. > > > Thanks, > > Ying Zheng > >
