----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32946/#review83174 -----------------------------------------------------------
Have shared my views on the API here. Haven't reviewed the rest of the patch https://issues.apache.org/jira/browse/FALCON-1095?focusedCommentId=14536986#comment-14536986 Also can we drop the "schedulable" entityType and include a specific entity or include all entities. (in which case we would make entityType optional for this api). Reason for suggesting this is to avoid excluding clusters specifically when entitites are being searched. Dont recall seeing any changes in the Authorization layer with respect to this change. Are there any needed ? - Srikanth Sundarrajan On April 27, 2015, 9:44 p.m., Ying Zheng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32946/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 9:44 p.m.) > > > Review request for Falcon, Ajay Yadava, Sowmya Ramesh, Seetharam Venkatesh, > and Venkat Ranganathan. > > > Bugs: Falcon-1121 > https://issues.apache.org/jira/browse/Falcon-1121 > > > Repository: falcon-git > > > Description > ------- > > See parent JIRA Falcon-1095 for detailed descriptions: > http://issues.apache.org/jira/browse/Falcon-1095 > Four changes in total: > 1. Added API support: return feeds and processes if :entity-type is set to > schedulable; change parameter for subsequence matching from "pattern" to > "nameseq"; multi-keyword matching for entity tags with parameter "tagkeys". > 2. Added command line support. > 3. Added unit tests. > 4. Updated twiki. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 7d56b01 > client/src/main/java/org/apache/falcon/client/FalconClient.java fedcea6 > client/src/main/java/org/apache/falcon/entity/v0/Entity.java 7fb271d > client/src/main/java/org/apache/falcon/resource/EntityList.java 4c96195 > common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java > b84371f > docs/src/site/twiki/FalconCLI.twiki 0e42ae2 > docs/src/site/twiki/restapi/EntityList.twiki 08dd304 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 25cb312 > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > 6198c74 > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > 6ccfd09 > prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java > 9b0dec5 > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > 82a622c > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java dd14e9c > webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java ee5534a > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 280253d > > Diff: https://reviews.apache.org/r/32946/diff/ > > > Testing > ------- > > Unit tests passed. Also tested command line and using api calls. > > > Thanks, > > Ying Zheng > >
