> On April 25, 2015, 3:25 a.m., Ajay Yadava wrote: > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java, line 408 > > <https://reviews.apache.org/r/32946/diff/7/?file=940062#file940062line408> > > > > This introduces one more allowed value for entityTypes field - > > "schedulable" . However, this value is allowed only for list option. > > > > This makes the behavior inconsistent. Also, since entityType - > > schedulable is not a valid enum type this makes it slightly unintuitive. > > For the UI purposes since we are passing the type as well, the filtering > > out for clusters should be done at UI end.
Good points raised regarding the schedulable behavior being inconsistent with other APIs. We discussed various options - not specifying the entity type in the URL path or giving more than (comma separated or some other separator) option for the entity type. We realized that this is only needed for list because other operations are specific to one entity of a particular type. And schedulable is a property for entitities and it seemed reasonable to expose this as an option to list entities having a specific attribute. We could get all the entities and filter them in the client (or UI), but independent of building that capability in the client/UI, it would be good to get a list of all schedulable entities which have common operations like schedule, suspend, resume (apart from create and delete which is shared by all entities) In future, if we change the url path to remove entity types or make them optional, we can come up with an optional parameter to identify the schedulable entities - Venkat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32946/#review81504 ----------------------------------------------------------- On April 27, 2015, 9:44 p.m., Ying Zheng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32946/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 9:44 p.m.) > > > Review request for Falcon, Ajay Yadava, Sowmya Ramesh, Seetharam Venkatesh, > and Venkat Ranganathan. > > > Bugs: Falcon-1121 > https://issues.apache.org/jira/browse/Falcon-1121 > > > Repository: falcon-git > > > Description > ------- > > See parent JIRA Falcon-1095 for detailed descriptions: > http://issues.apache.org/jira/browse/Falcon-1095 > Four changes in total: > 1. Added API support: return feeds and processes if :entity-type is set to > schedulable; change parameter for subsequence matching from "pattern" to > "nameseq"; multi-keyword matching for entity tags with parameter "tagkeys". > 2. Added command line support. > 3. Added unit tests. > 4. Updated twiki. > > > Diffs > ----- > > client/src/main/java/org/apache/falcon/cli/FalconCLI.java 7d56b01 > client/src/main/java/org/apache/falcon/client/FalconClient.java fedcea6 > client/src/main/java/org/apache/falcon/entity/v0/Entity.java 7fb271d > client/src/main/java/org/apache/falcon/resource/EntityList.java 4c96195 > common/src/main/java/org/apache/falcon/entity/store/ConfigurationStore.java > b84371f > docs/src/site/twiki/FalconCLI.twiki 0e42ae2 > docs/src/site/twiki/restapi/EntityList.twiki 08dd304 > prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java > 25cb312 > > prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java > 6198c74 > > prism/src/main/java/org/apache/falcon/resource/proxy/SchedulableEntityManagerProxy.java > 6ccfd09 > prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java > 9b0dec5 > > webapp/src/main/java/org/apache/falcon/resource/SchedulableEntityManager.java > 82a622c > webapp/src/test/java/org/apache/falcon/cli/FalconCLIIT.java dd14e9c > webapp/src/test/java/org/apache/falcon/cli/FalconCLISmokeIT.java ee5534a > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 280253d > > Diff: https://reviews.apache.org/r/32946/diff/ > > > Testing > ------- > > Unit tests passed. Also tested command line and using api calls. > > > Thanks, > > Ying Zheng > >
