----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40636/#review109125 -----------------------------------------------------------
unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java (line 363) <https://reviews.apache.org/r/40636/#comment168552> Instead of creating map every time, can this be simplified if you use JSONObject and convert to String finally webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java (line 87) <https://reviews.apache.org/r/40636/#comment168554> Name should be LOCAL_MODE webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java (line 93) <https://reviews.apache.org/r/40636/#comment168553> Is sharedLibService required for tests? if not please remove sharedlibservice from startup.properties in setup method. Please look https://issues.apache.org/jira/browse/FALCON-1447 webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java (line 152) <https://reviews.apache.org/r/40636/#comment168555> This method is only scheduling process but method name seems it will schedule all webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java (line 159) <https://reviews.apache.org/r/40636/#comment168556> Pls change this method name also as it is not only scheduling process - pavan kumar kolamuri On Nov. 26, 2015, 12:47 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40636/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 12:47 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1577 > https://issues.apache.org/jira/browse/FALCON-1577 > > > Repository: falcon-git > > > Description > ------- > > In this jira, we migrate EntityManagerJerseyIT using falcon unit. > > > Diffs > ----- > > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9eb4277 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 2a73516 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 23c59f4 > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java > 6458b59 > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java > 1d49353 > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 804b2ed > > Diff: https://reviews.apache.org/r/40636/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
