> On Dec. 14, 2015, 5:30 a.m., Pallavi Rao wrote: > > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java, > > line 143 > > <https://reviews.apache.org/r/40636/diff/2/?file=1147466#file1147466line143> > > > > May be we can move these methods to a common utility class. That way, > > all tests can use them.
Makes sense. will add a common utility class. > On Dec. 14, 2015, 5:30 a.m., Pallavi Rao wrote: > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, > > line 65 > > <https://reviews.apache.org/r/40636/diff/2/?file=1147467#file1147467line65> > > > > As mentioned in my previous comment, move these methods to a common > > utility class and reuse. Will do the same. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40636/#review110163 ----------------------------------------------------------- On Nov. 26, 2015, 12:47 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40636/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2015, 12:47 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1577 > https://issues.apache.org/jira/browse/FALCON-1577 > > > Repository: falcon-git > > > Description > ------- > > In this jira, we migrate EntityManagerJerseyIT using falcon unit. > > > Diffs > ----- > > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9eb4277 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 2a73516 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > 23c59f4 > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java > 6458b59 > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java > 1d49353 > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 804b2ed > > Diff: https://reviews.apache.org/r/40636/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
