> On Dec. 14, 2015, 12:21 p.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, > > line 88 > > <https://reviews.apache.org/r/40636/diff/3/?file=1162213#file1162213line88> > > > > Change this name as i said in previous comments
I will change the name. > On Dec. 14, 2015, 12:21 p.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java, > > line 65 > > <https://reviews.apache.org/r/40636/diff/3/?file=1162213#file1162213line65> > > > > These methods are repetitive please put in common location and use for > > both the tests Agreed. All these tests will be put in a common class and these tests should extend this class. > On Dec. 14, 2015, 12:21 p.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java, line 189 > > <https://reviews.apache.org/r/40636/diff/3/?file=1162215#file1162215line189> > > > > Narayan, please raise a jira to cleanup these test later, As we have > > multiple methods for same functionality Ok. Will do all the cleanup related stuff in a separate jira. > On Dec. 14, 2015, 12:21 p.m., pavan kumar kolamuri wrote: > > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java, line 190 > > <https://reviews.apache.org/r/40636/diff/3/?file=1162215#file1162215line190> > > > > In that jira create AbstractContext and make TestContext and > > UnitTestContext extends that. Agreed. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40636/#review110203 ----------------------------------------------------------- On Dec. 14, 2015, 9:03 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40636/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 9:03 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1577 > https://issues.apache.org/jira/browse/FALCON-1577 > > > Repository: falcon-git > > > Description > ------- > > In this jira, we migrate EntityManagerJerseyIT using falcon unit. > > > Diffs > ----- > > unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 9eb4277 > unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 2a73516 > webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java > abe5bdd > > webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java > 6458b59 > webapp/src/test/java/org/apache/falcon/resource/UnitTestContext.java > 1d49353 > webapp/src/test/java/org/apache/falcon/util/OozieTestUtils.java 804b2ed > > Diff: https://reviews.apache.org/r/40636/diff/ > > > Testing > ------- > > Done. > > > Thanks, > > Narayan Periwal > >
