----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40698/#review109478 -----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java (line 122) <https://reviews.apache.org/r/40698/#comment169057> Pallavi can you add description in jira what touch will do in native scheduler scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 346) <https://reviews.apache.org/r/40698/#comment169055> I didn't get what exactly touch is doing. We are just creating staging path. Will it be useful when effective time come into picture ? scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 363) <https://reviews.apache.org/r/40698/#comment169052> As of now effective time is always in future (now + 3 mins). Won't it break backward compatability ? - pavan kumar kolamuri On Dec. 4, 2015, 12:06 p.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40698/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 12:06 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1512 > https://issues.apache.org/jira/browse/FALCON-1512 > > > Repository: falcon-git > > > Description > ------- > > Touch feature was not implemented for native scheduler. Adding it now. > > > Diffs > ----- > > scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java > ebc05ec > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > ac7cde8 > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java > 70c8353 > scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java > 087114f > > Diff: https://reviews.apache.org/r/40698/diff/ > > > Testing > ------- > > Manual testing done. Couldn't add UTs are there are interactions with Oozie. > > > Thanks, > > Pallavi Rao > >
