> On Dec. 14, 2015, 9:38 a.m., pavan kumar kolamuri wrote: > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java, > > line 353 > > <https://reviews.apache.org/r/40698/diff/3/?file=1153803#file1153803line353> > > > > What if process is already ended by that time ? Aren't we giving wrong > > message ? > > Pallavi Rao wrote: > There might be a small window when the a new instance can be scheduled > when we are doing the touch. In such a case, the message will show effective > time just before touch takes effect. Agreed. But, I don't know if it is worth > trying to figure the exact time and add the additional complexity. > > Pallavi Rao wrote: > Sorry. Misunderstood your comment. Added an additional check.
Thanks pallavi - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40698/#review110183 ----------------------------------------------------------- On Dec. 15, 2015, 6:21 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40698/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 6:21 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1512 > https://issues.apache.org/jira/browse/FALCON-1512 > > > Repository: falcon-git > > > Description > ------- > > Touch feature was not implemented for native scheduler. Adding it now. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/util/DateUtil.java b70fa20 > > oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java > 91230b2 > > scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java > 2a2589e > scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java > ebc05ec > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > ac7cde8 > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java > 70c8353 > scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java > 087114f > > Diff: https://reviews.apache.org/r/40698/diff/ > > > Testing > ------- > > Manual testing done. Couldn't add UTs are there are interactions with Oozie. > > > Thanks, > > Pallavi Rao > >
