----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40698/#review109721 -----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 387) <https://reviews.apache.org/r/40698/#comment169338> It will be useful to provide this as a utility method in DateUtil class. scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 394) <https://reviews.apache.org/r/40698/#comment170198> Will it make sense to put this also in DateUtil. This is often used whenever someone uses ```EntityUtil.getNextStartTime```. - Ajay Yadava On Dec. 4, 2015, 12:06 p.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40698/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 12:06 p.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1512 > https://issues.apache.org/jira/browse/FALCON-1512 > > > Repository: falcon-git > > > Description > ------- > > Touch feature was not implemented for native scheduler. Adding it now. > > > Diffs > ----- > > scheduler/src/main/java/org/apache/falcon/workflow/engine/DAGEngine.java > ebc05ec > > scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java > ac7cde8 > > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java > 70c8353 > scheduler/src/test/java/org/apache/falcon/execution/MockDAGEngine.java > 087114f > > Diff: https://reviews.apache.org/r/40698/diff/ > > > Testing > ------- > > Manual testing done. Couldn't add UTs are there are interactions with Oozie. > > > Thanks, > > Pallavi Rao > >
