> On Dec. 11, 2015, 6:50 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java,
> >  line 141
> > <https://reviews.apache.org/r/41203/diff/1/?file=1158687#file1158687line141>
> >
> >     Looks like it will only solve launching instances in FIFO order, it 
> > won't solve use case of instances not getting scheduled. Please correct me 
> > if i am missing something

It does solve the original problem too. I put out the details of the issue and 
the fix on the JIRA.


- Pallavi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41203/#review109926
-----------------------------------------------------------


On Dec. 10, 2015, 12:51 p.m., Pallavi Rao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41203/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2015, 12:51 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1572
>     https://issues.apache.org/jira/browse/FALCON-1572
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Wrong Datastructure was used to load and store into cache.
> 
> 
> Diffs
> -----
> 
>   scheduler/pom.xml 336997d 
>   
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java
>  ace8444 
> 
> Diff: https://reviews.apache.org/r/41203/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done. Once ITs are checked in, will add a test case for this 
> too.
> 
> 
> Thanks,
> 
> Pallavi Rao
> 
>

Reply via email to