----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41203/#review110179 -----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java (line 32) <https://reviews.apache.org/r/41203/#comment169954> Just curious 0,3,5 are given so that to add more priorities right ? Then i feel 0,5,10 might be better to accomodate more priorities scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java (line 203) <https://reviews.apache.org/r/41203/#comment169956> Will synchronization hold when get is directly used even though it is in synchronized block ? It should be accessed through iterator right ? - pavan kumar kolamuri On Dec. 11, 2015, 9:24 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41203/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 9:24 a.m.) > > > Review request for Falcon. > > > Bugs: FALCON-1572 > https://issues.apache.org/jira/browse/FALCON-1572 > > > Repository: falcon-git > > > Description > ------- > > Wrong Datastructure was used to load and store into cache. > > > Diffs > ----- > > scheduler/pom.xml 336997d > scheduler/src/main/java/org/apache/falcon/execution/EntityExecutor.java > 88d88c1 > scheduler/src/main/java/org/apache/falcon/execution/ExecutionInstance.java > 5f96d3f > > scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java > b6741a4 > > scheduler/src/main/java/org/apache/falcon/execution/NotificationHandler.java > b071f5f > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java > 23f2b4e > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/SchedulerService.java > ace8444 > > scheduler/src/test/java/org/apache/falcon/notification/service/SchedulerServiceTest.java > c43ccf0 > > Diff: https://reviews.apache.org/r/41203/diff/ > > > Testing > ------- > > Manual testing done. Once ITs are checked in, will add a test case for this > too. > > > Thanks, > > Pallavi Rao > >
