> On Dec. 30, 2015, 7:32 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/request/DataNotificationRequest.java, > > line 111 > > <https://reviews.apache.org/r/39632/diff/3/?file=1176409#file1176409line111> > > > > As mentioned above, you can use pollStartTime. That way, this setter > > won't be required. > > pavan kumar kolamuri wrote: > Will think of using poll start time and update
When building this service even i thought of doing something w.r.t to poll start time, but in that approach delay time in queue also comes into effect while checking request until timeout. Suppose request has 10 secs timeout and polling frequency 2 secs, it might be in queue for 2 secs if queue is busy, then we end up delaying one more time since we thought it came second. And also with this approach there is chance that request might not check for 5 times eventhough polling frequency is 2 secs and timeout is 10 secs. With the current approach this was taken using queuetime. > On Dec. 30, 2015, 7:32 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/request/DataNotificationRequest.java, > > line 176 > > <https://reviews.apache.org/r/39632/diff/3/?file=1176409#file1176409line176> > > > > isFirst may not be required, if acceesTime is initialized to > > pollStartTime. > > pavan kumar kolamuri wrote: > Ok will check and update Explained the differences between approaches in previous comments. > On Dec. 30, 2015, 7:32 a.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java, > > line 189 > > <https://reviews.apache.org/r/39632/diff/3/?file=1176408#file1176408line189> > > > > The request can be ignored in the Event consumer itself, saves some > > computation. Yes make sense will do this as well. - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39632/#review112285 ----------------------------------------------------------- On Dec. 26, 2015, 6:52 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39632/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2015, 6:52 a.m.) > > > Review request for Falcon. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-1230 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1230 > > > Repository: falcon-git > > > Description > ------- > > Data Availability Service for Falcon . It will notify When Data paths are > available. > > > Diffs > ----- > > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java > 72e5558 > > scheduler/src/main/java/org/apache/falcon/notification/service/event/DataEvent.java > 1036339 > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java > 7ffb351 > > scheduler/src/main/java/org/apache/falcon/notification/service/request/DataNotificationRequest.java > 8393de0 > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java c7b4f12 > > scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java > d66972c > > scheduler/src/test/java/org/apache/falcon/notification/service/DataAvailabilityServiceTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39632/diff/ > > > Testing > ------- > > Unit Tests are written > > > Thanks, > > pavan kumar kolamuri > >
