> On Jan. 6, 2016, 12:32 p.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java, > > line 166 > > <https://reviews.apache.org/r/39632/diff/4/?file=1180737#file1180737line166> > > > > As discussed dets delegate this to Request.hasTimeout() method. The > > DataAvailabilityService shouldn't worry about this logic.
Yes will fix > On Jan. 6, 2016, 12:32 p.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java, > > line 171 > > <https://reviews.apache.org/r/39632/diff/4/?file=1180737#file1180737line171> > > > > As discussed dets delegate this to Request.accessed() method. The > > DataAvailabilityService shouldn't worry about this logic. ok sure will fix > On Jan. 6, 2016, 12:32 p.m., Pallavi Rao wrote: > > scheduler/src/main/java/org/apache/falcon/notification/service/request/DataNotificationRequest.java, > > line 78 > > <https://reviews.apache.org/r/39632/diff/4/?file=1180738#file1180738line78> > > > > What happens during Falcon restarts, since we are not polling how long > > we have polled. The polling will start all over again and an instance which > > was supposed to, lets say, time out at 2nd hour (from instance time), might > > time-out much later than that. As of know its only taking from created time , will think about this in next patch along with refactoring of DataNotification Request - pavan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39632/#review113057 ----------------------------------------------------------- On Jan. 7, 2016, 11:52 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39632/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 11:52 a.m.) > > > Review request for Falcon. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-1230 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1230 > > > Repository: falcon-git > > > Description > ------- > > Data Availability Service for Falcon . It will notify When Data paths are > available. > > > Diffs > ----- > > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java > 72e5558 > > scheduler/src/main/java/org/apache/falcon/notification/service/event/DataEvent.java > 1036339 > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java > 7ffb351 > > scheduler/src/main/java/org/apache/falcon/notification/service/request/DataNotificationRequest.java > 8393de0 > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java c7b4f12 > > scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java > d66972c > > scheduler/src/test/java/org/apache/falcon/notification/service/DataAvailabilityServiceTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39632/diff/ > > > Testing > ------- > > Unit Tests are written > > > Thanks, > > pavan kumar kolamuri > >
