----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39632/#review113057 -----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java (line 165) <https://reviews.apache.org/r/39632/#comment173565> As discussed dets delegate this to Request.hasTimeout() method. The DataAvailabilityService shouldn't worry about this logic. scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java (line 170) <https://reviews.apache.org/r/39632/#comment173566> As discussed dets delegate this to Request.accessed() method. The DataAvailabilityService shouldn't worry about this logic. scheduler/src/main/java/org/apache/falcon/notification/service/request/DataNotificationRequest.java (line 69) <https://reviews.apache.org/r/39632/#comment173568> What happens during Falcon restarts, since we are not polling how long we have polled. The polling will start all over again and an instance which was supposed to, lets say, time out at 2nd hour (from instance time), might time-out much later than that. - Pallavi Rao On Jan. 4, 2016, 10:21 a.m., pavan kumar kolamuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39632/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 10:21 a.m.) > > > Review request for Falcon. > > > Bugs: https://issues.apache.org/jira/browse/FALCON-1230 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FALCON-1230 > > > Repository: falcon-git > > > Description > ------- > > Data Availability Service for Falcon . It will notify When Data paths are > available. > > > Diffs > ----- > > > scheduler/src/main/java/org/apache/falcon/execution/ProcessExecutionInstance.java > 72e5558 > > scheduler/src/main/java/org/apache/falcon/notification/service/event/DataEvent.java > 1036339 > > scheduler/src/main/java/org/apache/falcon/notification/service/impl/DataAvailabilityService.java > 7ffb351 > > scheduler/src/main/java/org/apache/falcon/notification/service/request/DataNotificationRequest.java > 8393de0 > scheduler/src/main/java/org/apache/falcon/predicate/Predicate.java c7b4f12 > > scheduler/src/test/java/org/apache/falcon/execution/FalconExecutionServiceTest.java > d66972c > > scheduler/src/test/java/org/apache/falcon/notification/service/DataAvailabilityServiceTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/39632/diff/ > > > Testing > ------- > > Unit Tests are written > > > Thanks, > > pavan kumar kolamuri > >
