> On Jan. 27, 2016, 3:10 a.m., sandeep samudrala wrote: > > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java, > > line 555 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181571#file1181571line555> > > > > In case of distributed mode, if this validation is not happening for > > each cluster(at serverlevel) defined in the feed, this may not work.
Checking all the clusters. > On Jan. 27, 2016, 3:10 a.m., sandeep samudrala wrote: > > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java, > > line 567 > > <https://reviews.apache.org/r/41916/diff/1/?file=1181571#file1181571line567> > > > > getRetentionQueue will validate only the queue mentioned in lifecycle > > if present and not the normal retention queue mentioned in the feed > > definition. First, tries Lifecycle and if that is null, gets the queue name from the feed property. public static String getRetentionQueue(Feed feed, Cluster feedCluster) throws FalconException { String queueName; queueName = getLifecycleRetentionQueue(feed, feedCluster.getName()); if (queueName == null) { queueName = getQueueFromProperties(feed); } return queueName; } - Venkatesan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41916/#review116527 ----------------------------------------------------------- On Feb. 10, 2016, 10:32 p.m., Venkatesan Ramachandran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41916/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 10:32 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Validate the hadoop cluster queue name specified in the Feed entity during > feed submit. > > The implementation uses Resource Manager REST API to get hadoop cluster queue > names. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java b3aaaab > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java > 981e730 > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java > 10a5265 > common/src/main/java/org/apache/falcon/util/HadoopQueueUtil.java > PRE-CREATION > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 95d10c4 > common/src/test/java/org/apache/falcon/util/HadoopQueueUtilTest.java > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-1.json > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-2.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/41916/diff/ > > > Testing > ------- > > Unit tests > Manual end to end tests > Secure cluster test > > > Thanks, > > Venkatesan Ramachandran > >
