> On Feb. 11, 2016, 12:25 a.m., Sowmya Ramesh wrote: > > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java, > > line 554 > > <https://reviews.apache.org/r/41916/diff/2/?file=1239854#file1239854line554> > > > > nit: Use constants
used only one place. > On Feb. 11, 2016, 12:25 a.m., Sowmya Ramesh wrote: > > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java, > > lines 567-569 > > <https://reviews.apache.org/r/41916/diff/2/?file=1239854#file1239854line567> > > > > can we use LOG.info(" {}", ) instead of format the same message is logged and throws in exception. > On Feb. 11, 2016, 12:25 a.m., Sowmya Ramesh wrote: > > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java, > > line 588 > > <https://reviews.apache.org/r/41916/diff/2/?file=1239854#file1239854line588> > > > > Since queueList is set, contains check not required. N/A > On Feb. 11, 2016, 12:25 a.m., Sowmya Ramesh wrote: > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java, > > line 355 > > <https://reviews.apache.org/r/41916/diff/2/?file=1239855#file1239855line355> > > > > use LOG.info({}, ) instead of string format message is logged and thown. - Venkatesan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41916/#review118761 ----------------------------------------------------------- On Feb. 11, 2016, 12:26 a.m., Venkatesan Ramachandran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41916/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2016, 12:26 a.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Validate the hadoop cluster queue name specified in the Feed entity during > feed submit. > > The implementation uses Resource Manager REST API to get hadoop cluster queue > names. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/EntityUtil.java 24dbf3d > common/src/main/java/org/apache/falcon/entity/FeedHelper.java b3aaaab > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java > 981e730 > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java > 10a5265 > common/src/main/java/org/apache/falcon/util/HadoopQueueUtil.java > PRE-CREATION > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 95d10c4 > common/src/test/java/org/apache/falcon/util/HadoopQueueUtilTest.java > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-1.json > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-2.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/41916/diff/ > > > Testing > ------- > > Unit tests > Manual end to end tests > Secure cluster test > > > Thanks, > > Venkatesan Ramachandran > >
