----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41916/#review118761 -----------------------------------------------------------
common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1223) <https://reviews.apache.org/r/41916/#comment180064> same line repeated again, typo? common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1242) <https://reviews.apache.org/r/41916/#comment180065> use StringUtils.isBlank common/src/main/java/org/apache/falcon/entity/FeedHelper.java (lines 1259 - 1260) <https://reviews.apache.org/r/41916/#comment180067> minor nit: String queueName = getLifecycleRetentionQueue(feed, feedCluster.getName()); - init in same line common/src/main/java/org/apache/falcon/entity/FeedHelper.java (line 1261) <https://reviews.apache.org/r/41916/#comment180066> same as above common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 554) <https://reviews.apache.org/r/41916/#comment180069> nit: Use constants common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 555) <https://reviews.apache.org/r/41916/#comment180070> use StringUtils.isBlank common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 559) <https://reviews.apache.org/r/41916/#comment180071> nit: use strignUtils.isNotBlank common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (lines 567 - 569) <https://reviews.apache.org/r/41916/#comment180072> can we use LOG.info(" {}", ) instead of format common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 587) <https://reviews.apache.org/r/41916/#comment180086> use StringUtils common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java (line 588) <https://reviews.apache.org/r/41916/#comment180087> Since queueList is set, contains check not required. common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java (line 355) <https://reviews.apache.org/r/41916/#comment180088> use LOG.info({}, ) instead of string format - Sowmya Ramesh On Feb. 10, 2016, 10:32 p.m., Venkatesan Ramachandran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41916/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2016, 10:32 p.m.) > > > Review request for Falcon. > > > Repository: falcon-git > > > Description > ------- > > Validate the hadoop cluster queue name specified in the Feed entity during > feed submit. > > The implementation uses Resource Manager REST API to get hadoop cluster queue > names. > > > Diffs > ----- > > common/src/main/java/org/apache/falcon/entity/FeedHelper.java b3aaaab > common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java > 981e730 > > common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java > 10a5265 > common/src/main/java/org/apache/falcon/util/HadoopQueueUtil.java > PRE-CREATION > common/src/test/java/org/apache/falcon/entity/FeedHelperTest.java 95d10c4 > common/src/test/java/org/apache/falcon/util/HadoopQueueUtilTest.java > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-1.json > PRE-CREATION > common/src/test/resources/config/feed/feed-schedulerinfo-2.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/41916/diff/ > > > Testing > ------- > > Unit tests > Manual end to end tests > Secure cluster test > > > Thanks, > > Venkatesan Ramachandran > >
