+1 Build and tests- OK Signature - verified Checksums - verified On Thu, Aug 4, 2016 at 9:26 AM, Ajay Yadava <ajayyad...@apache.org> wrote:
> Hi Balu, > > Sorry that I did not finish all the checks in RC0 itself or even now. I am > preparing to relocate to a different continent > and unable to give it the time it deserves to do a complete check. I would > be happy to convert my vote to +1, if someone > convinces me that the following are not an issue. > > > 1. Bootstrap license > I didn't notice it earlier and it seems that unlike earlier > bootstrap(licensed only under MIT), library we have > used has dual license (MIT and Apache Software License 2.0) and can be used > under ASL 2.0 and hence > probably need not mention in the LICENSE.txt. > > However, bootstrap includes *normalize.css* which is licensed under MIT > only(see line 9 in bootstrap.min.css) which will still need to be mentioned > in the LICENSE. > > > 2. Entypo license > > > *<quote>2. Entypo license is covered under line 242 in LICENSE.txt</quote>* > > INAL, but I believe Entypo is mentioned under LICENSE.txt but since it is > CC BY-SA we need to > update the NOTICE along with the License. > > > 3. > *<quote>* > > *All angular js related licenses are covered under line 229* > *</quote>* > This may really be a non-issue and you may be right here. My reason for > bringing it up is > because I suspect that these are not part of plain angular.min.js download > and are separate > helper packages from angular, which if correct, might require them to be > mentioned > separately in LICENSE, even though they have same origin and license. > > > 4. Other files > *./falcon-ui/app/js/lib/bootstrap.notify.js [MIT only] - no mention in > LICENSE* > not part of bootstrap distribution. Quoting from the source below > /* > * Project: Bootstrap Notify = v3.0.2 > * Description: Turns standard Bootstrap alerts into "Growl-like" > notifications. > * Author: Mouse0270 aka Robert McIntosh > * License: MIT License > * Website: https://github.com/mouse0270/bootstrap-growl > */ > > *./falcon-ui/app/js/lib/checklist-model.js * > Following is the header: > /** > * Checklist-model > * AngularJS directive for list of checkboxes > */ > It should have ASL header if it's original work contributed directly to > Apache Falcon. > Absence of Google copyright suggests it is not part of angular js either. > > *./falcon-ui/app/js/lib/popover.js * > No ASL header, no other hints on source of origin either. > > > FWIW, technically -1 is not a veto for releases and this vote may pass as > per the guidelines [1] > so you may not need to put out another RC. > > [1] http://www.apache.org/foundation/voting.html#ReleaseVotes > > Regards > Ajay Yadava > > On Thu, Aug 4, 2016 at 2:42 AM Balu Vellanki Bala < > bvella...@hortonworks.com> > wrote: > > > Hi Ajay > > > > 1. There is docs/license/bootstrap-LICENSE.txt for bootstrap. Angular > > bootstrap license is listed in LICENSE.txt at line 232, > > "This product bundles angular-ui-bootstrap 0.11.0 which is available > under > > a > > MIT license. For details, see > > docs/license/angular-ui-bootstrap-LICENSE.txt" > > > > > > All angular js related licenses are covered under line 229 > > "This product bundles angularJS 1.3.5 which is available under a > > MIT license. For details, see docs/license/angularJS-LICENSE.txt" > > This product bundles entypo icons which is available under a > > CC BY-SA license and Font is available under SIL license. > > For details, see docs/license/entypo-icons-LICENSE.txt and > > docs/license/entypo-font-LICENSE.txt" > > > > > > If you agree, please recast your vote. > > > > Balu Vellanki > > > > On 8/3/16, 1:13 PM, "Ajay Yadava" <ajayyad...@apache.org> wrote: > > > > >-1 (binding) > > > > > >because: > > >1. Following libraries are being bundled as part of the source but don't > > >have any mention in the license > > > > > > - bootstrap > > > - Following add on libraries for angular js are not distributed as > part > > > of angular.min.js and hence also deserve separate mention AFAIK [ > > > angular-mocks.js, angular-messages.min.js, angular-cookies.min.js, > > > angular-animate.min.js ] > > > - checklist-model.js > > > > > >2. entypo icons are being used, which are licensed under CC-BY SA which > I > > >believe requires a mention in NOTICE also. > > > > > >I haven't yet looked at everything, will let you know if I find more > > >issues. Thank you for driving this release Balu! > > > > > >Regards > > >Ajay Yadava > > > > > >On Wed, Aug 3, 2016 at 7:19 PM Peeyush Bishnoi > > ><bpeey...@yahoo.co.in.invalid> > > >wrote: > > > > > >> Verified the release candidate > > >> - Checksums (MD5, SHA) - MATCH > > >> - Signature - GOOD > > >> - Build - SUCCESSFUL (default & distributed) > > >> +1 > > >> > > >> On Wednesday, 3 August 2016 12:53 PM, Jean-Baptiste Onofré < > > >> j...@nanthrax.net> wrote: > > >> > > >> > > >> +1 (binding) > > >> > > >> Build successfully. Legal files look OK. > > >> > > >> Regards > > >> JB > > >> > > >> On 08/03/2016 09:22 AM, Pallavi Rao wrote: > > >> > +1 > > >> > > > >> > Signature - OK > > >> > Checksums - OK > > >> > Build - OK > > >> > Licenses - OK > > >> > > > >> > Thanks a bunch, Balu, for driving the release! > > >> > > > >> > > > >> > On Wed, Aug 3, 2016 at 9:08 AM, Venkat Ranganathan < > > >> > vranganat...@hortonworks.com> wrote: > > >> > > > >> >> +1 > > >> >> > > >> >> Built and ran tests successfully > > >> >> Verified signatures and checksums > > >> >> Validated licenses > > >> >> > > >> >> > > >> >> One thing we should do going forward is to add some attention > calling > > >> >> sequence – like a line full of ‘*’ to point to the fact that > > >>CHANGES.txt > > >> >> does not have changes from Release 0.10 onwards. > > >> >> > > >> >> Thanks Balu for driving the release and working through the issues > > >> >> > > >> >> Thanks > > >> >> > > >> >> Venkat > > >> >> > > >> >> > > >> >> On 8/2/16, 4:32 PM, "Balu Vellanki Bala" < > bvella...@hortonworks.com> > > >> >> wrote: > > >> >> > > >> >> Hello Everyone, > > >> >> > > >> >> This is the call for vote for the following Release Candidate > RC2 > > >>to > > >> be > > >> >> released as official Apache Falcon 0.10 release. This RC2 > > >>addressed > > >> all > > >> >> feedback provided for RC0, plus fixed bugs FALCON-2104 and > > >> FALCON-2107 > > >> >> found in RC0/RC1. The source tar ball, signature and checksum > > >>files > > >> >> can be > > >> >> downloaded from > > >> >> > > >> >> > > >> > > >> > > > https://dist.apache.org/repos/dist/dev/falcon/apache-falcon-0.10-sources/ > > >> >> > > >> >> You can find the signing key here : > > >> >> > http://pgp.mit.edu/pks/lookup?op=vindex&search=0xF743ABF42E887C76 > > >> >> > > >> >> You can find the KEYS file here: > > >> >> https://dist.apache.org/repos/dist/release/falcon/KEYS > > >> >> > > >> >> > > >> >> To verify signature: > > >> >> gpg --verify apache-falcon-0.10-sources.tar.gz.asc > > >> >> apache-falcon-0.10-sources.tar.gz > > >> >> > > >> >> Git tag commit-id for the release : release-0.10-rc2 > > >> >> > > >> >> > > >> > > >> > > > https://git-wip-us.apache.org/repos/asf?p=falcon.git;a=commit;h=dc4129598 > > >>d9 > > >> >> afed9ca9e4210d7c04f80e458ff3f > > >> >> > > >> >> We have closed around several JIRAs as part of this release, the > > >> >> details > > >> >> of which can be found here: > > >> >> > > >> >> > > >> > > >> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12334758&s > > >>ty > > >> >> leName=Html&projectId=12314429 > > >> >> > > >> >> > > >> >> Please find the release notes with brief explanation on key > > >>changes > > >> at > > >> >> > > >> >> > > >> > > >> > > > https://issues.apache.org/jira/secure/attachment/12821716/FalconReleaseNo > > >>te > > >> >> s-0.10.pdf > > >> >> Note: The hyper link ³migration instructions² under section-5 is > > >>set > > >> to > > >> >> > > >> >> > > >> > > >> > > > https://svn.apache.org/repos/asf/falcon/site/0.10/MigrationInstructions.h > > >>tm > > >> >> l, this link will only be available post release, once the > Falcon > > >> >> documentation site is updated. At this moment, it will not work. > > >> >> > > >> >> > > >> >> > > >> >> This vote will remain open for at least 72 hours. Please vote on > > >> >> releasing > > >> >> this RC2 > > >> >> > > >> >> [ ] +1 approve > > >> >> [ ] +0 no opinion > > >> >> [ ] -1 disapprove (and reason why) > > >> >> > > >> >> +1 from my side > > >> >> > > >> >> Thank you > > >> >> Balu Vellanki > > >> >> > > >> >> > > >> >> > > >> >> > > >> >> > > >> > > > >> > > >> -- > > >> Jean-Baptiste Onofré > > >> jbono...@apache.org > > >> http://blog.nanthrax.net > > >> Talend - http://www.talend.com > > >> > > >> > > >> > > > > >
