[ 
https://issues.apache.org/jira/browse/FELIX-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619312#action_12619312
 ] 

Alin Dreghiciu commented on FELIX-102:
--------------------------------------

Lets say we have bundle Av1  which is a singleton with symbolic name S and Av2 
which is a singleton with symbolic name S.
The patch works for the situations when:
1. one of the bundles is installed and resolved and the second one is not. Then 
when you install the second bundle the check will kick in and throw the 
exception so second bundle will not be resolved.
2. none of the bundles is installed, then you install/resolve one of the 
bundles and then install and resolve the second bundle. 

The patch does not work for the situation where:
1. you install one of the bundles, then install the other one. Then both 
bundles will get resolved when you do a start for example due to the station I 
explained in the email before
2. you install and resolve one of the bundles, install the other one. The 
second installed one will not get resolved. But when you shutdown the framework 
and restart it you can resolve both bundles due to the same reasons as 
explained.

Another point is that the exception thrown is a ResolveException and when the 
framework will display the fact that there is a problem resolving the bundle i 
will show something like:
org.osgi.framework.BundleException: Unresolved constraint in bundle 8: null
this because the resolve exception has a null Requirement. I suggest that this 
to be changed to show the exception message if the requirement is null.

Bottom line I think that this is a step further and you should commit your 
patch + a fix related to exception message. Then we can add the solution to the 
check of indirect resolving bundles later on. 

> Implement singleton bundle support
> ----------------------------------
>
>                 Key: FELIX-102
>                 URL: https://issues.apache.org/jira/browse/FELIX-102
>             Project: Felix
>          Issue Type: New Feature
>          Components: Framework, Specification compliance
>            Reporter: Richard S. Hall
>            Assignee: Richard S. Hall
>            Priority: Minor
>             Fix For: felix-1.2.0
>
>         Attachments: FELIX-102.patch, singleton.patch
>
>
> Section 3.5.2 of the OSGi R4 core specification describes singleton bundles. 
> Felix does not currently support this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to