oops, just realize I was mixing gogo.shell + gogo.jline.shell. With only gogo.jline.shell, it works perfectly without any NPE ... I have cancelled FELIX-5382 (again, sorry for the noise [...]).
/pierre On Mon, Oct 17, 2016 at 3:08 PM, Pierre De Rop <pierre.de...@gmail.com> wrote: > My bad, I made a wrong manipulation with a corrupted ~/.gogo.history file. > I removed the file and it's now working fine (sorry for the noise). > > however, I'm still having the NPE at LineReaderImpl.java:262, but it does > not seem to cause any troubles. > > I'm voting +1 but I have created FELIX-5382 about the NPE seen. > > thanks; > BR > /Pierre > > > > > > > On Mon, Oct 17, 2016 at 9:02 AM, Guillaume Nodet <gno...@apache.org> > wrote: > >> 2016-10-14 17:51 GMT+02:00 Pierre De Rop <pierre.de...@gmail.com>: >> >> > Thanks Raymond, Guillaume; >> > >> > I'm sorry, but I have downloaded org.jline 3.0.0 from >> > http://repo1.maven.org/maven2/org/jline/jline/3.0.0/, >> > >> >> Yes, that's correct. >> >> The StringIndexOutOfBoundsException is caused by an error parsing the >> history file which syntax is different. You can delete your >> ~/.gogo.history file to get rid of that one. I suppose it may be better >> to >> use a different file to avoid those problem though. >> >> For the NPE, I'm not sure, what's your OS / terminal ? What bundles do you >> load ? >> >> Guillaume >> >> >> > and I still have the following errors: >> > >> > [nxuser@nx0012 felix-framework-5.6.0]$ java -jar bin/felix.jar >> > gogo: NullPointerException: null >> > gogo: NullPointerException: null >> > java.lang.NullPointerException >> > at java.util.Objects.requireNonNull(Objects.java:203) >> > at >> > org.jline.reader.impl.LineReaderImpl.<init>(LineReaderImpl.java:262) >> > at >> > org.jline.reader.LineReaderBuilder.build(LineReaderBuilder.java:90) >> > at org.apache.felix.gogo.jline.Shell.gosh(Shell.java:297) >> > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> > at >> > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAcce >> > ssorImpl.java:62) >> > at >> > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMe >> > thodAccessorImpl.java:43) >> > at java.lang.reflect.Method.invoke(Method.java:498) >> > at >> > org.apache.felix.gogo.runtime.Reflective.invoke(Reflective.java:136) >> > at >> > org.apache.felix.gogo.runtime.CommandProxy.execute(CommandPr >> oxy.java:82) >> > at >> > org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:548) >> > at >> > org.apache.felix.gogo.runtime.Closure.executeStatement(Closu >> re.java:474) >> > at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:3 >> 63) >> > at org.apache.felix.gogo.runtime.Pipe.doCall(Pipe.java:417) >> > at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:227) >> > at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) >> > at java.util.concurrent.FutureTask.run(FutureTask.java:266) >> > at >> > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool >> > Executor.java:1142) >> > at >> > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo >> > lExecutor.java:617) >> > at java.lang.Thread.run(Thread.java:745) >> > ____________________________ >> > Welcome to Apache Felix Gogo >> > >> > gogoStringIndexOutOfBoundsException: String index out of range: -1 >> > java.lang.StringIndexOutOfBoundsException: String index out of range: >> -1 >> > at java.lang.String.substring(String.java:1967) >> > at >> > org.jline.reader.impl.history.DefaultHistory.lambda$load$0(D >> > efaultHistory.java:80) >> > at java.util.Iterator.forEachRemaining(Iterator.java:116) >> > at >> > java.util.Spliterators$IteratorSpliterator.forEachRemaining( >> > Spliterators.java:1801) >> > at >> > java.util.stream.ReferencePipeline$Head.forEach( >> > ReferencePipeline.java:580) >> > at >> > org.jline.reader.impl.history.DefaultHistory.load(DefaultHis >> tory.java:78) >> > at >> > org.jline.reader.impl.history.DefaultHistory.attach(DefaultH >> > istory.java:66) >> > at >> > org.jline.reader.impl.LineReaderImpl.readLine(LineReaderImpl.java:444) >> > at org.apache.felix.gogo.jline.Shell.runShell(Shell.java:396) >> > at org.apache.felix.gogo.jline.Shell.gosh(Shell.java:323) >> > at >> > org.apache.felix.gogo.jline.Activator.doStartShell(Activator.java:150) >> > at >> > org.apache.felix.gogo.jline.Activator.lambda$startShell$0(Ac >> > tivator.java:106) >> > at java.lang.Thread.run(Thread.java:745) >> > >> > is it really the right download url for jline: >> > http://repo1.maven.org/maven2/org/jline/jline/3.0.0/ ? >> > >> > thanks >> > /pierre >> > >> > On Fri, Oct 14, 2016 at 5:32 PM, Guillaume Nodet <gno...@apache.org> >> > wrote: >> > >> > > Right, and the groupId has changed from jline to org.jline >> > > >> > > 2016-10-14 17:16 GMT+02:00 Raymond Auge <raymond.a...@liferay.com>: >> > > >> > > > The gogo.jline bundle pom shows jline 3.0.0 >> > > > >> > > > https://repository.apache.org/content/repositories/ >> > > > orgapachefelix-1146/org/apache/felix/org.apache.felix. >> > > > gogo.jline/1.0.0/org.apache.felix.gogo.jline-1.0.0.pom >> > > > >> > > > HTH, >> > > > - Ray >> > > > >> > > > On Fri, Oct 14, 2016 at 10:23 AM, Pierre De Rop < >> > pierre.de...@gmail.com> >> > > > wrote: >> > > > >> > > > > Hi, >> > > > > >> > > > > Guillaume, I'm trying to test the release. To do so, I have >> replaced >> > my >> > > > > gogo bundles with the bundles from this release candidate, but >> what >> > > jline >> > > > > version should I use ? >> > > > > >> > > > > I tried jline-3.0.0.M1.jar, but using this version, I'm then >> having >> > the >> > > > > following problem: >> > > > > >> > > > > java -jar bin/felix.jar >> > > > > Exception in thread "Gogo shell" java.lang.NoSuchMethodError: >> > > > > org.jline.terminal.TerminalBuilder.nativeSignals( >> > > Z)Lorg/jline/terminal/ >> > > > > TerminalBuilder; >> > > > > at >> > > > > org.apache.felix.gogo.jline.Activator.doStartShell(Activator >> > .java:134) >> > > > > at >> > > > > org.apache.felix.gogo.jline.Activator.lambda$startShell$0( >> > > > > Activator.java:106) >> > > > > at java.lang.Thread.run(Thread.java:745) >> > > > > gogo: NullPointerException: null >> > > > > gogo: NullPointerException: null >> > > > > java.lang.NullPointerException >> > > > > at java.util.Objects.requireNonNull(Objects.java:203) >> > > > > at >> > > > > org.jline.reader.impl.LineReaderImpl.<init>(LineReaderImpl.j >> ava:260) >> > > > > at >> > > > > org.jline.reader.LineReaderBuilder.build(LineReaderBuilder.j >> ava:90) >> > > > > at org.apache.felix.gogo.jline.Shell.gosh(Shell.java:297) >> > > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native >> > Method) >> > > > > at >> > > > > sun.reflect.NativeMethodAccessorImpl.invoke( >> > > > NativeMethodAccessorImpl.java: >> > > > > 62) >> > > > > at >> > > > > sun.reflect.DelegatingMethodAccessorImpl.invoke( >> > > > > DelegatingMethodAccessorImpl.java:43) >> > > > > at java.lang.reflect.Method.invoke(Method.java:498) >> > > > > at >> > > > > org.apache.felix.gogo.runtime.Reflective.invoke(Reflective.j >> ava:136) >> > > > > at >> > > > > org.apache.felix.gogo.runtime.CommandProxy.execute( >> > > CommandProxy.java:82) >> > > > > at >> > > > > org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.jav >> a:548) >> > > > > at >> > > > > org.apache.felix.gogo.runtime.Closure.executeStatement( >> > > Closure.java:474) >> > > > > at org.apache.felix.gogo.runtime. >> > Closure.execute(Closure.java: >> > > > 363) >> > > > > at org.apache.felix.gogo.runtime. >> Pipe.doCall(Pipe.java:417) >> > > > > at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:227) >> > > > > at org.apache.felix.gogo.runtime.Pipe.call(Pipe.java:59) >> > > > > at java.util.concurrent.FutureTas >> k.run(FutureTask.java:266) >> > > > > at >> > > > > java.util.concurrent.ThreadPoolExecutor.runWorker( >> > > > > ThreadPoolExecutor.java:1142) >> > > > > at >> > > > > java.util.concurrent.ThreadPoolExecutor$Worker.run( >> > > > > ThreadPoolExecutor.java:617) >> > > > > at java.lang.Thread.run(Thread.java:745) >> > > > > >> > > > > I'm using the following bundles, using Felix framework 5.6.0 (with >> > java >> > > > > 1.8.0_102): >> > > > > >> > > > > org.apache.felix.bundlerepository-2.0.8.jar >> > > > > org.apache.felix.gogo.command-1.0.0.jar >> > > > > org.apache.felix.gogo.jline-1.0.0.jar >> > > > > org.apache.felix.gogo.runtime-1.0.0.jar >> > > > > org.apache.felix.gogo.shell-1.0.0.jar >> > > > > jline-3.0.0.M1.jar >> > > > > >> > > > > Am I testing with the wrong jline version ? >> > > > > >> > > > > thank you; >> > > > > >> > > > > BR >> > > > > /Pierre >> > > > > >> > > > > On Wed, Oct 12, 2016 at 2:11 PM, Raymond Auge < >> > > raymond.a...@liferay.com> >> > > > > wrote: >> > > > > >> > > > > > +1 (non-binding) >> > > > > > >> > > > > > On Wed, Oct 12, 2016 at 7:18 AM, Achim Nierbeck < >> > > > bcanh...@googlemail.com >> > > > > > >> > > > > > wrote: >> > > > > > >> > > > > > > +1 (non-binding) >> > > > > > > >> > > > > > > regards, Achim >> > > > > > > >> > > > > > > 2016-10-12 13:16 GMT+02:00 Jean-Baptiste Onofré < >> j...@nanthrax.net >> > >: >> > > > > > > >> > > > > > > > +1 (binding) >> > > > > > > > >> > > > > > > > Regards >> > > > > > > > JB >> > > > > > > > >> > > > > > > > >> > > > > > > > On 10/12/2016 01:14 PM, Christian Schneider wrote: >> > > > > > > > >> > > > > > > >> +1 (non binding) >> > > > > > > >> >> > > > > > > >> Christian >> > > > > > > >> >> > > > > > > >> On 11.10.2016 21:31, Guillaume Nodet wrote: >> > > > > > > >> >> > > > > > > >>> As discussed on the mailing list, I've staged a 1.0.0 >> release >> > > of >> > > > > the >> > > > > > > gogo >> > > > > > > >>> bundles at >> > > > > > > >>> https://repository.apache.org/ >> content/repositories/orgap >> > > > > > > >>> achefelix-1146 >> > > > > > > >>> >> > > > > > > >>> This includes all the bundles versioned at 1.0.0. >> > > > > > > >>> The requirement are >> > > > > > > >>> * JDK 7 >> > > > > > > >>> * JDK 8 for the gogo.jline bundle >> > > > > > > >>> >> > > > > > > >>> I've removed the status=provisional, bumped the package to >> > > > version >> > > > > > > 1.0.0, >> > > > > > > >>> moved the CommandSessionListener in the same place than >> the >> > > > > > > >>> CommandProcessor / CommandSession, etc... >> > > > > > > >>> >> > > > > > > >>> There are small incompatibilities, hence the requirement >> for >> > a >> > > > > major >> > > > > > > >>> bump, >> > > > > > > >>> and I think a 1.0 release is definitely missing anyway. >> > > > > > > >>> >> > > > > > > >>> To test it, you can use the felix distribution and replace >> > the >> > > > > > bundles >> > > > > > > >>> with >> > > > > > > >>> the new ones, either use gogo.runtime + gogo.shell on >> JDK7 or >> > > > > > > >>> gogo.runtime >> > > > > > > >>> + gogo.jline + jline on JDK8. >> > > > > > > >>> The gogo.jline bundle provides history, completion and >> quite >> > a >> > > > few >> > > > > > nice >> > > > > > > >>> things you really ought to try ! >> > > > > > > >>> >> > > > > > > >>> Please review and vote ! >> > > > > > > >>> >> > > > > > > >>> Cheers, >> > > > > > > >>> Guillaume Nodet >> > > > > > > >>> >> > > > > > > >>> >> > > > > > > >> >> > > > > > > >> >> > > > > > > > -- >> > > > > > > > Jean-Baptiste Onofré >> > > > > > > > jbono...@apache.org >> > > > > > > > http://blog.nanthrax.net >> > > > > > > > Talend - http://www.talend.com >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > -- >> > > > > > > >> > > > > > > Apache Member >> > > > > > > Apache Karaf <http://karaf.apache.org/> Committer & PMC >> > > > > > > OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/> >> > > > > Committer >> > > > > > & >> > > > > > > Project Lead >> > > > > > > blog <http://notizblog.nierbeck.de/> >> > > > > > > Co-Author of Apache Karaf Cookbook <http://bit.ly/1ps9rkS> >> > > > > > > >> > > > > > > Software Architect / Project Manager / Scrum Master >> > > > > > > >> > > > > > >> > > > > > >> > > > > > >> > > > > > -- >> > > > > > *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile >> > >> > > > > > (@rotty3000) >> > > > > > Senior Software Architect *Liferay, Inc.* < >> http://www.liferay.com> >> > > > > > (@Liferay) >> > > > > > Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> >> > > > > > (@OSGiAlliance) >> > > > > > >> > > > > >> > > > >> > > > >> > > > >> > > > -- >> > > > *Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile> >> > > > (@rotty3000) >> > > > Senior Software Architect *Liferay, Inc.* <http://www.liferay.com> >> > > > (@Liferay) >> > > > Board Member & EEG Co-Chair, OSGi Alliance <http://osgi.org> >> > > > (@OSGiAlliance) >> > > > >> > > >> > > >> > > >> > > -- >> > > ------------------------ >> > > Guillaume Nodet >> > > ------------------------ >> > > Red Hat, Open Source Integration >> > > >> > > Email: gno...@redhat.com >> > > Web: http://fusesource.com >> > > Blog: http://gnodet.blogspot.com/ >> > > >> > >> >> >> >> -- >> ------------------------ >> Guillaume Nodet >> ------------------------ >> Red Hat, Open Source Integration >> >> Email: gno...@redhat.com >> Web: http://fusesource.com >> Blog: http://gnodet.blogspot.com/ >> > >
