Hey Viswa, It's going to take me a little longer to get to merging and reviewing this, so please be patient with me. But a couple of comments while you're waiting:
1.) That you're not seeing those error messages probably may not mean they are gone. It may mean that they are now "hidden" in the docker image. That's not ideal for error messages. It makes debugging harder when there really is an issue. 2.) Thank you for finding the error with the artifact path. Consider submitting a patch to fineract-cn-service-starter. I'm a bit concerned about the idea of moving this all into docker. Yes docker is one important method for deploying microservices, and showing an example of how to use those technologies is important. But the demo-server is also there partly to test code and get a local installation up and running. When I started on it, my intention was to support Mark van Veen so that he didn't have to start all the services and then provision by hand to work on the UI. Unfortunately there are serious problems with the demo-server the way it is now. It takes a huge amount of resources because it starts every service in its own process. Many developers do not have computers with sufficient resources to run this locally. At one point, Kuelap literally bought me a new computer after I had spent a couple of days unsuccessfully trying to make the demo-server work because Markus had added a couple more services to it. Moving these processes into containers doesn't solve this problem. Docker works with computing resources in a shockingly efficient manner, so it probably doesn't actually make the problem worse, but it does make the problem harder to solve. Another point, is that currently I can start these services in debug mode, and attack a debugger to them to understand tricky problems. I don't know how to do that in a docker container. Any changes in that direction should consider this use case. I can see that testing this running in docker might be important for some of our users and contributors. But I don't want it to be the default. I would feel more comfortable with your change sets if you made this "more optional". My first priority for this project is to enable contributors. To do that, I'd like to look for ways to run all of the services in one process for the purposes of local testing and debugging. Best Regards, Myrle Krantz Committer, Apache Fineract On Fri, Mar 2, 2018 at 3:35 AM, Viswa Ramamoorthy <[email protected]> wrote: > Hi, > I have raised a PR with docker compose yml for Eureka and ActiveMQ. > It is https://github.com/apache/fineract-cn-demo-server/pull/3 > Please note that after I launch Eureka and ActiveMQ via Docker, I do not see > JMS connect error as well as Eureka registration error anymore. > But service launch was failing with below errorCould not find artifact > io.mifos.provisioner:service-boot:jar:0.1.0-BUILD-SNAPSHOT > Locally was able to fix artifact path to "org.apache.fineract.cn." in > fineract-cn-service-starter and move forward with service launch. > But there were more errors. I have not looked into further yet. > I think demo server needs some more work to get it to work consistently. All > of the services can be launched via shell script if there are no start up > dependencies between them > Regards > Viswa
