+1 seems reasonable to me. Will this also affect PRs which has changed requested by reviewer?
On Tue, Jul 21, 2026, 10:26 PM James Dailey <[email protected]> wrote: > +1 > > > Sent from Gmail Mobile > > On Tue, Jul 21, 2026 at 9:45 AM Adam Monsen <[email protected]> wrote: > >> When your PR is approved, do you then push additional commits? If so, why? >> >> If a PR is approved, the next step is to merge it, not to make more >> unapproved changes. >> >> *I propose we enforce this by policy for the apache/fineract repo.* >> >> When I'm reviewing a PR, I'd be surprised if it changes *after* I >> approve it. >> >> My proposal is here <https://github.com/apache/fineract/pull/6155>. With >> that PR, additional post-approval commits require re-approval. This closes >> a loophole for accidents or bad behavior. >> >> +1 / 0 / -1 / thoughts? Please add a thumbs-up / thumbs-down to that PR >> or discuss it here on-list. >> >
