+1 On Wed, 22 Jul 2026 at 16:28, KRISHNA MEWARA <[email protected]> wrote:
> +1 > > On Wed, 22 Jul, 2026, 16:10 Linos T Darikai, <[email protected]> > wrote: > >> +1 I think this will help in review to avoid unnecessary confusion. >> >> On Wed, Jul 22, 2026 at 12:39 PM Tofunmi Oguntibeju < >> [email protected]> wrote: >> >>> +1. >>> >>> I support this change. Dismissing stale approvals when new commits are >>> pushed ensures reviews reflect the latest code, reduces the risk of >>> outdated approvals being merged, and aligns with common GitHub branch >>> protection best practices. >>> >>> On Tue, Jul 21, 2026 at 5:45 PM Adam Monsen <[email protected]> wrote: >>> >>>> When your PR is approved, do you then push additional commits? If so, >>>> why? >>>> >>>> If a PR is approved, the next step is to merge it, not to make more >>>> unapproved changes. >>>> >>>> *I propose we enforce this by policy for the apache/fineract repo.* >>>> >>>> When I'm reviewing a PR, I'd be surprised if it changes *after* I >>>> approve it. >>>> >>>> My proposal is here <https://github.com/apache/fineract/pull/6155>. >>>> With that PR, additional post-approval commits require re-approval. This >>>> closes a loophole for accidents or bad behavior. >>>> >>>> +1 / 0 / -1 / thoughts? Please add a thumbs-up / thumbs-down to that PR >>>> or discuss it here on-list. >>>> >>>
