+1 On Tue, Jul 21, 2026, 11:58 Adam Monsen <[email protected]> wrote:
> On Tue, Jul 21, 2026 at 9:59 AM Aman Mittal <[email protected]> > wrote: > >> +1 seems reasonable to me. Will this also affect PRs which has changed >> requested by reviewer? >> > > It would, yes, but a reviewer shouldn't approve a PR until all requested > changes are complete. A reviewer can also revert an approval at any time > (say if it was made in error). > > Note: We already have required_conversation_resolution: true > <https://github.com/apache/fineract/blob/86edc6b19963e2e73ac5a2ad1926843f6832568f/.asf.yaml#L32> > blocking the merge until conversations (questions, requested changes, etc.) > are resolved. I see dismissing stale reviews as an additional enhancement > along the same lines, codifying more of our community's definition of "when > is a PR approved/ok/ready to merge?" >
