Ok,
Going to reply again.
It just keeps getting better as I look. You know I understand this is
a Apache but, if you can just go into this code and just change crap
like you did without at least talking on list first, I'm just going to
fork my code on GIT and leave Apache.
This is crap Erik, yeah I'm upset. The amount of changes you made
without consulting the "list" is not the way I would do it. Adding
stuff is different, but when you just go in and completely refactor
MAJOR stuff it makes me feel like I'm just this guy that is invisible
to you.
Sorry about this attitude but I have one right now. I would never have
done this to community code without talking about it first but, that
is just me.
Mike
Quoting Michael Schmalle <apa...@teotigraphix.com>:
I'm going to reply to my own post here.
I disagree with where you put Emitter.
Until we support more parsed languages... Emitter belongs in
internal.as.codegen.
I don not think common packages should have sub packages. If you
want a driver package put it under compiler. If you want a common
codegen, put it under compiler.
Your changes in this commit caused 136 errors in my project's impl
and test suite.
If we can't talk about these massive types of changes first, I will
veto the commit and ask you to revert, then we can talk.
We still need to decide about these changes because I don't agree
with the above stated.
Mike
Quoting Michael Schmalle <apa...@teotigraphix.com>:
Erik,
I was wondering if we could agree, that before we move packages
around that we could have a discussion first about the
implications? I almost had a heart attack looking at the last svn
update log. I seriously don't want to veto any commits but the
farther we go with the development of the core visitor framework,
the more code that is being built on it, specifically a couple
projects of mine.
Major refactors can be very disruptive.
What is your strategy with MXML? Your implementation of vanilla,
your are creating instances with the 'new' operator?
Are you planning on implementing Alex's data structures?
Mike
--
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com
--
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com
--
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com
