Erik,

Thanks for looking into these issues.  I'm wondering if this is the right
fix, though.  I haven't actually pulled your changes, so I'm just looking at
the diff.

It appears that this commit switches from a change event on enter to a
change event on every keystroke in the TextInput portion of the
NumericStepper.  If I didn't read it right, then ignore the rest of this
email.  My concerns are that this will trigger databinding on every
keystroke, and will trigger validators on every keystroke as well, which
could cause invalid results temporarily since many numbers may be out of
range as you type.  For example, if you wanted to enter "-1" the validator
may trigger as soon as you type '-'.

In reading the two bugs, it makes me think that something else is broken
regarding FLEX-33505.  As soon as the user clicked on something to dismiss
the popup, focus should have been lost which should have triggered a
FOCUS_OUT which should have caused the NS to commit its text.  The other bug
also implies that NS is not handling FOCUS_OUT correctly, so maybe there is
a fix needed in FOCUS_OUT handling.

I believe there are several places in the Flex SDK where a CHANGE event is
not dispatched from the component until you lose focus or hit ENTER so that
binding and validators don't fire so often.

If my understanding is correct, can you revisit this fix?


On 5/14/13 2:22 AM, "Erik de Bruin" <e...@ixsoftware.nl> wrote:

> Nice!
> 
> EdB
> 
> 
> 
> On Tue, May 14, 2013 at 11:15 AM, Justin Mclean
> <jus...@classsoftware.com> wrote:
>> HI,
>> 
>> Actually not that one but I've probably fixed that myself :-)
>> 
>> Justin
> 
> 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Reply via email to