Hi Mike, I checkout out the code from fluint.googlecode.com. An examination of the logs indicates that Xavi contributed files in FlexUnit4CIRunner as well as FlexUnit4UIRunner. Does that match your understanding? Were those files brought into GitHub?
I also see he made a small change to some other files in other folders, but I don't think that needs to be worried about at this point. Did any Adobe folks contribute any new files once you were in GitHub? In my understanding it doesn't matter whether there are Adobe copyright files in FlexUnit as far as releasing FlexUnit because those files are under BSD. It just means that we have to preserve the Adobe headers in those files and document which files are Adobe in the License and the IP Clearance form and maybe make a note in the Software Grant. At some point, I will get those files donated, including FlexUnitLib so we can change headers and make life a bit easier. But my understanding is that isn't a priority. It won't block making a release. So, after we get your answer about FlexUnit4CIRunner, I think we will be able to build a list of files that need to have the Adobe copyright. Can you grep the GitHub repo and see if you see any other Adobe copyrights and headers? I do not have a way to see the Software Grants, but in poking at history in GitHub, it looks like there were many contributions from blegros. Was he on work-for-hire by DP? Did he co-sign the grant or otherwise give permission for his work to be donated? Other than that, we still have to get an answer from the Incubator on how to deal with the IP Clearance form. Meanwhile, someone can make sure that Apache's flex-flexunit repo has Adobe headers on the files in that list. Then once that's all done we can vote on a release. FWIW, I did get FlexUnit4CIRunner to work with FlexJS and Ant so I don't have any blocking technical issues with the RC Justin made. -Alex On 3/25/14 6:50 PM, "Michael A. Labriola" <labri...@digitalprimates.net> wrote: >>Thicker still, I found this: >>http://opensource.adobe.com/svn//opensource/flexunit/trunk/FlexUnitLib/ > >Good find Alex. I didn't realize the UI was checked in here. This looks >like the original version checked in by Alistair on August 15th, 2008. I >think we can use this repo as part of our reference. > >>Mike, can you validate that the list of files on Adobe svn is in fact >>the source for FlexUnit1Lib and is it also the same set of files that >>was the starting point for FlexUnit4? > >This is the actual source of the FlexUnit1 lib. It's just a tag instead >of the trunk. >http://opensource.adobe.com/svn/opensource/flexunit/tags/0.9/ > >I will verify if AbstractRowData is in the actual SWC for us just for >good measure, but I think it's fair to assume some of these files are. >Now, to be clear, this isn't really the starting point for FlexUnit4 at >all. However, some of these files are the starting point for the >FlexUnit4 subproject, affectionately called the UIListener. It should be >noted that none of these are needed to deploy FlexUnit4 for use with CI >or any IDE. This code is _only_ used as a separate UI for those running >from command line or web browser. I bring up that point as we could >release a version of FlexUnit without the UI runner. This code is for an >add on project contributed by Adobe but not intrinsic to FlexUnit4. > >>Then I think that would be the list for #1 unless Adobe folks >>contributed other files after that point. > >The link I sent earlier to google code shows that Xavi, then an Adobe >employee, contributed the code in the branch I mention above to the >google code repository and continued to modify it. I am bringing that up >as the code in the repo above is not the last code touched by Adobe in >some capacity. So, to see the last code touched by Adobe, one needs to >look here > >http://fluint.googlecode.com/svn/branches/skunkworks/flexUnit4/flexUnit4UI >Runner/ > >-Mike