Hi Alex,
thanks! for the inline problem, I cherry pick your commit in mdl branch and
add the code you suggested to the mdl example project, test it and it's
working, and showing the plus icon inside :)
A side of the success, maybe this should work with plain js:Button, since
this is really a icon button...
For the second problem, then I check the differences in UIBase/UIButtonBase
className setters and see UIButtonBase lacks:
COMPILE::JS
{
element.className = typeNames ? value + ' ' + typeNames
: value;
}
but my mdl button extends UIBase and not UIButtonBase (maybe it should be
the last...)
So here my main problem is that at that level (chose base comp extension) I
don't know the reasons to use one over another. I close the first one as my
copy paste of the basic button. In Flat there's no extension.
Anyway my test here doesn't throws what we expected and the button (via
component code) still is unstylised.
Checking UIButtonBase it seems is mainly surrounded by COMPILE::SWF and
there's COMPILE::JS (only in the className method), so this confuses
me...what is generating the compiler here? since there's a COMPILE::JS
inside COMPILE::SWF, in my understanding, there should be only SWF
generation...
Thanks
Carlos
2016-10-16 8:55 GMT+02:00 Alex Harui <aha...@adobe.com>:
> Also, I'm out of time for tonight, but I took a quick look and found that
> UIButtonBase.as doesn't have the same className setter as UIBase.as. I'll
> bet if you copy the UIBase setter to UIButtonBase your other problem will
> go away.
>
> HTH,
> -Alex
>
> On 10/15/16, 11:45 PM, "Alex Harui" <aha...@adobe.com> wrote:
>
> >Well, that took longer than I hoped. I also have limited time this
> >weekend. Anyway, I think I got the following pattern to work:
> >
> ><js:TextButton className="mdl-button mdl-js-button mdl-button--fab
> >mdl-button--colored">
> > <i class="material-icons">add</i>
> ></js:TextButton>
> >
> >
> >Note that I'm using TextButton as it has 'text' and 'html' properties.
> >The Button class doesn't (currently) have those properties as it is used
> >primarily for graphic buttons like up/down arrows in scrollbars, numeric
> >steppers, etc.
> >
> >I had to add [DefaultProperty("text")] to TextButton. That was pushed to
> >the flex-asjs develop branch so you will need to sync that to your branch.
> >
> >I also had to add
> >
> > xmlns="http://www.w3.org/1999/xhtml";
> >
> >to the top of the mxml file containing the TextButton. The compiler is
> >specifically looking for tags in that namespace to know those tags are
> >html and not mapped to some component. We can add other namespaces if we
> >need to.
> >
> >I'm pretty sure the code I pushed to flex-falcon needs to be generalized
> >to handle more complex HTML. Right now it expects the "content" to be a
> >single HTML tag with children. I'll work on that shortly.
> >
> >Anyway, hope that gets you a bit further.
> >
> >
> >-Alex
> >
> >
> >
> >On 10/14/16, 11:25 PM, "carlos.rov...@gmail.com on behalf of Carlos
> >Rovira" <carlos.rov...@gmail.com on behalf of
> >carlos.rov...@codeoscopic.com> wrote:
> >
> >>Thanks Alex,
> >>
> >>I'll be the next hours off, but if you get something I'll be looking it
> >>this weekend. Many thanks for your time!
> >>
> >>2016-10-15 8:07 GMT+02:00 Alex Harui <aha...@adobe.com>:
> >>
> >>>
> >>>
> >>> On 10/14/16, 2:07 PM, "carlos.rov...@gmail.com on behalf of Carlos
> >>>Rovira"
> >>> <carlos.rov...@gmail.com on behalf of carlos.rov...@codeoscopic.com>
> >>> wrote:
> >>>
> >>> >Hi Alex,
> >>> >
> >>> >just committed the MDLExample project in examples folder with minimal
> >>> >code,
> >>> >just a js:Button with styles that works and a mdl:Button that should
> >>>have
> >>> >that styles and doesn't work. I configure to build with maven, but not
> >>> >ant.
> >>>
> >>> OK. I'm still digging into the MXML parsing.
> >>>
> >>> -Alex
> >>>
> >>>
> >>
> >>
> >>--
> >>
> >>Carlos Rovira
> >>Director General
> >>M: +34 607 22 60 05
> >>http://www.codeoscopic.com
> >>http://www.avant2.es
> >>
> >>
> >>Este mensaje se dirige exclusivamente a su destinatario y puede contener
> >>información privilegiada o confidencial. Si ha recibido este mensaje por
> >>error, le rogamos que nos lo comunique inmediatamente por esta misma vía
> >>y
> >>proceda a su destrucción.
> >>
> >>De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> >>comunicamos
> >>que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
> >>S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> >>servicio o información solicitados, teniendo usted derecho de acceso,
> >>rectificación, cancelación y oposición de sus datos dirigiéndose a
> >>nuestras
> >>oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> >>necesaria.
> >
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
