Hi,

> I'm not saying the ApprovalScript is a requirement, I'm saying that that
> is what I use, so you can know up front what tests I am going to run so
> you can potentially save all of us time by making sure it passes those
> tests before offering another RC.

The ApprovalScript generally fails to me as it timeouts on downloading the 
artifacts or takes hours to do so. It also doesn’t test the actual RC just 
what’s built on the CI machine which in theory should be the same but that has 
bitten me a few times due to differences what’s in .git_ignore and similar. If 
it could test a RC I just made on my machine without downloading anything I 
would probably use it. It also picks up environment variables so I was never 
sure exactly what it was testing it's all a bit too black box for me. It runs 
rat with exclusions which from my experience in the incubator where most issues 
show up.  It probably works better in the US (where the server is located?) or 
for people who have better bandwidth connections.

I looked at a build from the saxon changes I just made and can confirm:
- saxon notice files are in source release
- saxon9.jar is in the binary
- asdocs works

Thanks,
Justin

Reply via email to