I agree wholeheartedly with Ufuk. We cannot reformat the codebase, cannot pause while flushing the PR queue, and won't find a consensus code style.
I think we can create a baseline code style for new and existing contributors for which reformatting on changed files will be acceptable for PR reviews. On Fri, Feb 24, 2017 at 5:01 AM, Dawid Wysakowicz < wysakowicz.da...@gmail.com> wrote: > The problem with code style when it is not enforced is that it will be a > matter of luck to what parts of files / new files will it be applied. When > the code style is not applied to whole file, it is pretty much useless > anyway. You would need to manually select just the fragments one is > changing. The benefits of having code style and enforcing it I see are: > - being able to apply autoformatter, which speeds up writing code > - it would make reviewing PRs easier as e.g. there would be line length > limit applied etc. which will make line breaking more reader friendly. > > Though I think if a consensus is not reachable it would be good to once and > forever decide that we don't want a code style and checkstyle. > > 2017-02-24 10:51 GMT+01:00 Ufuk Celebi <u...@apache.org>: > > > On Fri, Feb 24, 2017 at 10:46 AM, Fabian Hueske <fhue...@gmail.com> > wrote: > > > I agree with Till that encouraging a code style without enforcing it > does > > > not make a lot of sense. > > > If we enforce it, we need to touch all files and PRs. > > > > I think it makes sense for new contributors to have a starting point > > without enforcing anything (I do agree that we are past the point to > > reach consensus on a style and enforcement ;-)). > > >
