Hi Krzysztof, When I was building rc2, I tried to search whether issues with `fix version` of 1.16.0 have not been closed. https://issues.apache.org/jira/browse/FLINK-29627 was missed because the `fix version` was not marked. I agree with Martijn and Xintong that we won't block 1.16.0 on this.
Best, Xingbo Xintong Song <tonysong...@gmail.com> 于2022年10月20日周四 18:23写道： > Hi Krzysztof, > > FLINK-29627 is merged after rc2 being created, that's why it doesn't appear > in the change list. See the commit history of rc2 [1]. > > It's unfortunate this fix didn't make the 1.16.0 release (if rc2 is > approved). However, I agree with Martijn that we should not further block > 1.16.0 on this. If there's no other blockers discovered in the rc2, the fix > of FLINK-29627 will be shipped in 1.16.1. > > Best, > > Xintong > > > [1] https://github.com/apache/flink/commits/release-1.16.0-rc2 > > On Thu, Oct 20, 2022 at 6:16 PM Krzysztof Chmielewski < > krzysiek.chmielew...@gmail.com> wrote: > > > Thanks Martijn, > > just to clarify from my end, > > > > All three tickets, [1] [2] [3] are fixed and merged to 1.16 branch > > already. I just noticed that one of them [3] is not on included in the > > change list. Hence my email. > > > > [1] https://issues.apache.org/jira/browse/FLINK-29509 > > [2] https://issues.apache.org/jira/browse/FLINK-29512 > > [3] https://issues.apache.org/jira/browse/FLINK-29627 > > > > Regards, > > Krzysztof Chmielewski > > > > czw., 20 paź 2022 o 11:51 Martijn Visser <martijnvis...@apache.org> > > napisał(a): > > > > > Hi Krzysztof, > > > > > > Given that this issue already exists in previous Flink versions, I > don't > > > think it's a blocker for 1.16. We should get it fixed (all of the > > tickets) > > > so it will be addressed in a new Flink 1.15 version, in Flink 1.16.1 > and > > of > > > course Flink 1.17. > > > > > > Best regards, > > > > > > Martijn > > > > > > On Thu, Oct 20, 2022 at 11:47 AM Krzysztof Chmielewski < > > > krzysiek.chmielew...@gmail.com> wrote: > > > > > > > Hi, > > > > I would like to ask about [1] ticket with PR [2]. It was merged to > 1.16 > > > > release branch today but I do not see it on the change list. > > > > > > > > It is closely related to [3] and [4] that are on the change list. > > However > > > > to fully fix Sink architecture issue we need all 3 tickets [1], [3] > and > > > [4] > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-29627 > > > > [2] https://github.com/apache/flink/pull/21115 > > > > [3] https://issues.apache.org/jira/browse/FLINK-29509 > > > > [4] https://issues.apache.org/jira/browse/FLINK-29512 > > > > > > > > Regards, > > > > Krzysztof Chmielewski > > > > > > > > czw., 20 paź 2022 o 11:21 Xingbo Huang <h...@apache.org> napisał(a): > > > > > > > > > Hi everyone, > > > > > > > > > > Please review and vote on the release candidate #2 for the version > > > > 1.16.0, > > > > > as follows: > > > > > [ ] +1, Approve the release > > > > > [ ] -1, Do not approve the release (please provide specific > comments) > > > > > > > > > > The complete staging area is available for your review, which > > includes: > > > > > * JIRA release notes [1], > > > > > * the official Apache source release and binary convenience > releases > > to > > > > be > > > > > deployed to dist.apache.org [2], which are signed with the key > with > > > > > fingerprint 3C2C9FFB59DF9F3E [3], > > > > > * all artifacts to be deployed to the Maven Central Repository [4], > > > > > * source code tag "release-1.16.0-rc2" [5], > > > > > * website pull request listing the new release and adding > > announcement > > > > blog > > > > > post [6]. > > > > > > > > > > The vote will be open for at least 72 hours. It is adopted by > > majority > > > > > approval, with at least 3 PMC affirmative votes. > > > > > > > > > > Thanks, > > > > > Chesnay, Martijn, Godfrey & Xingbo > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351275 > > > > > [2] https://dist.apache.org/repos/dist/dev/flink/flink-1.16.0-rc2 > > > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > [4] > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1541 > > > > > [5] https://github.com/apache/flink/tree/release-1.16.0-rc2 > > > > > [6] https://github.com/apache/flink-web/pull/574 > > > > > > > > > > > > > > >
