[ 
https://issues.apache.org/jira/browse/FLUME-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450828#comment-13450828
 ] 

Christopher Nagy edited comment on FLUME-1491 at 9/8/12 4:51 AM:
-----------------------------------------------------------------

It looks like PropertiesFileConfigurationProvider does a lot of work besides 
loading the configuration from the property file. Probably the idea was to have 
other config file formats.
My idea for Zookeeper would be to add another ConfigurationProvider at the top 
level (and have it switchable in the Application). So the class hierarchy would 
be:

{noformat}
ConfigurationProvider
|
|- AbstractConfigurationProvider
   |
   |- AbstractFileConfigurationProvider
   |  |
   |  |- PropertiesFileConfigurationProvider
   |
   |- ZookeeperConfigurationProvider
{noformat}

AbstractConfigurationProvider would contain all the non-file related methods in 
AbstractFileConfigurationProvider and PropertiesFileConfigurationProvider. 
ZookeeperConfigurationProvider would create a FlumeConfiguration from data 
stored in Zookeeper and listen for changes on Zookeeper.

                
      was (Author: chris.nagy):
    It looks like PropertiesFileConfigurationProvider does a lot of work 
besides loading the configuration from the property file. Probably the idea was 
to have other config file formats.
My idea for Zookeeper would be to add another ConfigurationProvider at the top 
level (and have it switchable in the Application). So the class hierarchy would 
be:

<pre>
ConfigurationProvider
|
|- AbstractConfigurationProvider
   |
   |- AbstractFileConfigurationProvider
   |  |
   |  |- PropertiesFileConfigurationProvider
   |
   |- ZookeeperConfigurationProvider
</pre>

AbstractConfigurationProvider would contain all the non-file related methods in 
AbstractFileConfigurationProvider and PropertiesFileConfigurationProvider. 
ZookeeperConfigurationProvider would create a FlumeConfiguration from data 
stored in Zookeeper and listen for changes on Zookeeper.

                  
> Dynamic configuration from Zookeeper watcher
> --------------------------------------------
>
>                 Key: FLUME-1491
>                 URL: https://issues.apache.org/jira/browse/FLUME-1491
>             Project: Flume
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: v1.2.0
>            Reporter: Denny Ye
>            Assignee: Denny Ye
>              Labels: Zookeeper
>             Fix For: v1.3.0
>
>
> Currently, Flume only support file-level dynamic configuration. Another 
> frequent usage in practical environment, we would like to manage 
> configuration with Zookeeper, and modify configuration from Web UI to stored 
> file in Zookeeper. 
> Flume should support this method with Zookeeper watcher.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to