[ 
https://issues.apache.org/jira/browse/FLUME-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457575#comment-13457575
 ] 

Denny Ye commented on FLUME-1491:
---------------------------------

hi Christopher, thanks for your patch. I agree with most of your changes. Only 
two points I would like to explain my thought.
1. I reviewed patch and found that you chose configuration tree at Zookeeper. 
In my opinion, it's not easy to maintain and management. Original design of 
mine is only storing whole configuration file at Zookeeper, moving from local 
file. We can talk about tradeoff of both choices.
2. If we are using the simple structure talked above. Class hierarchy of 
ConfigurationProvider might be
{code:xml}
ConfigurationProvider
|
|- AbstractFileConfigurationProvider
   |
   |- PropertiesFileConfigurationProvider
   |
   |- ZookeeperConfigurationProvider
{code}
The difference between configuration provider is configuration file source, 
local file, Zookeeper or remote network,...

Wish to discuss with you

-Denny Ye
                
> Dynamic configuration from Zookeeper watcher
> --------------------------------------------
>
>                 Key: FLUME-1491
>                 URL: https://issues.apache.org/jira/browse/FLUME-1491
>             Project: Flume
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: v1.2.0
>            Reporter: Denny Ye
>            Assignee: Denny Ye
>              Labels: Zookeeper
>             Fix For: v1.3.0
>
>         Attachments: FLUME-1491-2.patch
>
>
> Currently, Flume only support file-level dynamic configuration. Another 
> frequent usage in practical environment, we would like to manage 
> configuration with Zookeeper, and modify configuration from Web UI to stored 
> file in Zookeeper. 
> Flume should support this method with Zookeeper watcher.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to