[ 
https://issues.apache.org/jira/browse/FLUME-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457828#comment-13457828
 ] 

Christopher Nagy commented on FLUME-1491:
-----------------------------------------

Hi Danny,

Do you mean that the whole properties string would be stored as a node value in 
ZooKeeper? If so, the ZooKeeperConfigurationProvider's reload method could be 
changed to read the value and call Properties#load (and remove the 
ZooKeeperConfigurationProvider#loadProperties method). 
I'm not sure that putting the ZooKeeperConfigurationProvider under 
AbstractFileConfigurationProvider is a good idea. The only functionality that 
AbstractFileConfigurationProvider provides (in the patch) is monitoring a local 
file for changes, while ZooKeeperConfigurationProvider needs to monitor a node 
(or nodes).
I guess it also comes down to how you want to specify which configuration 
provider to use. In the patch, it would be a new option (and a System property 
to specify the connection string). Maybe we could specify the connection string 
in the conf parameter (as a uri or something similar) and use a factory to 
decide which configuration provider.


                
> Dynamic configuration from Zookeeper watcher
> --------------------------------------------
>
>                 Key: FLUME-1491
>                 URL: https://issues.apache.org/jira/browse/FLUME-1491
>             Project: Flume
>          Issue Type: Improvement
>          Components: Configuration
>    Affects Versions: v1.2.0
>            Reporter: Denny Ye
>            Assignee: Denny Ye
>              Labels: Zookeeper
>             Fix For: v1.3.0
>
>         Attachments: FLUME-1491-2.patch
>
>
> Currently, Flume only support file-level dynamic configuration. Another 
> frequent usage in practical environment, we would like to manage 
> configuration with Zookeeper, and modify configuration from Web UI to stored 
> file in Zookeeper. 
> Flume should support this method with Zookeeper watcher.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to